Lose the user gesture expiration check on IdentifyReferrerChainByWebContents

chrome/browser/safe_browsing/safe_browsing_navigation_observer_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/safe_browsing/safe_browsing_navigation_observer.h"
 
 #include "base/test/histogram_tester.h"
 #include "chrome/browser/safe_browsing/safe_browsing_navigation_observer_manager.h"
 #include "chrome/browser/sessions/session_tab_helper.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
@@ skipping 231 matching lines @@
   EXPECT_EQ(nullptr,
             navigation_event_list()->FindNavigationEvent(url_1, GURL(), -1));
   EXPECT_THAT(histograms.GetAllSamples(kNavigationEventCleanUpHistogramName),
               testing::ElementsAre(base::Bucket(4, 1)));
 }
 
 TEST_F(SBNavigationObserverTest, TestCleanUpStaleUserGestures) {
   // Sets up user_gesture_map() such that it includes fresh, stale and invalid
   // user gestures.
   base::Time now = base::Time::Now();  // Fresh
-  base::Time one_minute_ago =
-      base::Time::FromDoubleT(now.ToDoubleT() - 60.0);  // Stale
+  base::Time three_minute_ago =

[lpz, 2017/05/17 20:22:04]

nit: three_minuteS_ago

[Jialiu Lin, 2017/05/17 20:58:24]

Good catch. Done.

+      base::Time::FromDoubleT(now.ToDoubleT() - 60.0 * 3);  // Stale
   base::Time in_an_hour =
       base::Time::FromDoubleT(now.ToDoubleT() + 60.0 * 60.0);  // Invalid
   AddTab(browser(), GURL("http://foo/1"));
   AddTab(browser(), GURL("http://foo/2"));
   content::WebContents* content0 =
       browser()->tab_strip_model()->GetWebContentsAt(0);
   content::WebContents* content1 =
       browser()->tab_strip_model()->GetWebContentsAt(1);
   content::WebContents* content2 =
       browser()->tab_strip_model()->GetWebContentsAt(2);
   user_gesture_map()->insert(std::make_pair(content0, now));
-  user_gesture_map()->insert(std::make_pair(content1, one_minute_ago));
+  user_gesture_map()->insert(std::make_pair(content1, three_minute_ago));
   user_gesture_map()->insert(std::make_pair(content2, in_an_hour));
   ASSERT_EQ(3U, user_gesture_map()->size());
 
   // Cleans up user_gesture_map()
   CleanUpUserGestures();
 
   // Verifies all stale and invalid user gestures are removed.
   ASSERT_EQ(1U, user_gesture_map()->size());
   EXPECT_NE(user_gesture_map()->end(), user_gesture_map()->find(content0));
   EXPECT_EQ(now, user_gesture_map()->at(content0));
@@ skipping 65 matching lines @@
   // Record a host-ip pair, neither of which has been seen before.
   std::string host_1 = GURL("http://bar/1").host();
   RecordHostToIpMapping(host_1, "9.9.9.9");
   ASSERT_EQ(2U, host_to_ip_map()->size());
   EXPECT_EQ(3U, host_to_ip_map()->at(host_0).size());
   EXPECT_EQ(1U, host_to_ip_map()->at(host_1).size());
   EXPECT_EQ("9.9.9.9", host_to_ip_map()->at(host_1).at(0).ip);
 }
 
 }  // namespace safe_browsing