Revert of Enable DCHECKs by default in non-official builds.

Revert of Enable DCHECKs by default in non-official builds. (patchset #3 id:40001 of https://codereview.chromium.org/2886803002/ )

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 472195 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzg3NWEyZmE0M2NhYWIwZWU4MmVmZTY4ZmI1YWRiMzU3MzkyNDM0YWQM

Original issue's description:
> Enable DCHECKs by default in non-official builds.
> 
> BUG=722827
> TBR=sdefresne@chromium.org for ios/
> 
> Review-Url: https://codereview.chromium.org/2886803002
> Cr-Commit-Position: refs/heads/master@{#472195}
> Committed: https://chromium.googlesource.com/chromium/src/+/875a2fa43caab0ee82efe68fb5adb357392434ad

TBR=brettw@chromium.org,thakis@chromium.org,sdefresne@chromium.org,gab@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=722827, 723090, 723049
Review-Url: https://codereview.chromium.org/2892473002
Cr-Commit-Position: refs/heads/master@{#472242}
Committed: https://chromium.googlesource.com/chromium/src/+/8cc767cb0d1c65af6d5a36858c9633c929b7e4cd

[findit-for-me, 2017-05-16 21:31:41]

Created Revert of Enable DCHECKs by default in non-official builds.

[findit-for-me, 2017-05-16 21:31:41]

findit-for-me@appspot.gserviceaccount.com changed reviewers:
+ dmazzoni@google.com, gab@google.com, kolos@google.com, peria@google.com

[findit-for-me, 2017-05-16 21:31:42]

Sheriffs:

Please confirm and "Quick L-G-T-M & CQ" this revert if it is correct.
If it is a false positive, please close it.

Findit (https://goo.gl/kROfz5) identified the original CL as the culprit
for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...

[dmazzoni, 2017-05-16 21:33:23]

dmazzoni@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[dmazzoni, 2017-05-16 21:33:23]

not lg

This seems like exactly the point of "Enable DCHECKs",
it should uncover new failures

[Nico, 2017-05-16 21:33:51]

On 2017/05/16 21:33:23, dmazzoni wrote:
> not lg
> 
> This seems like exactly the point of "Enable DCHECKs",
> it should uncover new failures

Well, it's a compile failure, not a run-time failure…

[dmazzoni, 2017-05-16 21:38:13]

On 2017/05/16 21:33:51, Nico wrote:
> On 2017/05/16 21:33:23, dmazzoni wrote:
> > not lg
> > 
> > This seems like exactly the point of "Enable DCHECKs",
> > it should uncover new failures
> 
> Well, it's a compile failure, not a run-time failure…

Oh, you're right.

Still, it's not failing on the main waterfall for whatever
reason. I'll try to just fix it.

[dmazzoni, 2017-05-16 21:44:08]

Not easy to test locally (needs libcras)
but looks simple to fix:

https://codereview.chromium.org/2886993002/

[dmazzoni, 2017-05-16 23:12:40]

lgtm

OK, landing the revert after all due to multiple failures that
haven't been fixed yet:

723090
723049

[dmazzoni, 2017-05-16 23:12:55]

Description was changed from

==========
Revert of Enable DCHECKs by default in non-official builds. (patchset #3
id:40001 of https://codereview.chromium.org/2886803002/ )

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 472195 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...

Original issue's description:
> Enable DCHECKs by default in non-official builds.
> 
> BUG=722827
> TBR=sdefresne@chromium.org for ios/
> 
> Review-Url: https://codereview.chromium.org/2886803002
> Cr-Commit-Position: refs/heads/master@{#472195}
> Committed:
https://chromium.googlesource.com/chromium/src/+/875a2fa43caab0ee82efe68fb5ad...

TBR=brettw@chromium.org,thakis@chromium.org,sdefresne@chromium.org,gab@chromi...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=722827
==========

to

==========
Revert of Enable DCHECKs by default in non-official builds. (patchset #3
id:40001 of https://codereview.chromium.org/2886803002/ )

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 472195 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...

Original issue's description:
> Enable DCHECKs by default in non-official builds.
> 
> BUG=722827
> TBR=sdefresne@chromium.org for ios/
> 
> Review-Url: https://codereview.chromium.org/2886803002
> Cr-Commit-Position: refs/heads/master@{#472195}
> Committed:
https://chromium.googlesource.com/chromium/src/+/875a2fa43caab0ee82efe68fb5ad...

TBR=brettw@chromium.org,thakis@chromium.org,sdefresne@chromium.org,gab@chromi...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=722827
==========

[dmazzoni, 2017-05-16 23:13:00]

The CQ bit was checked by dmazzoni@chromium.org

[dmazzoni, 2017-05-16 23:13:11]

The CQ bit was unchecked by dmazzoni@chromium.org

[dmazzoni, 2017-05-16 23:13:24]

Description was changed from

==========
Revert of Enable DCHECKs by default in non-official builds. (patchset #3
id:40001 of https://codereview.chromium.org/2886803002/ )

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 472195 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...

Original issue's description:
> Enable DCHECKs by default in non-official builds.
> 
> BUG=722827
> TBR=sdefresne@chromium.org for ios/
> 
> Review-Url: https://codereview.chromium.org/2886803002
> Cr-Commit-Position: refs/heads/master@{#472195}
> Committed:
https://chromium.googlesource.com/chromium/src/+/875a2fa43caab0ee82efe68fb5ad...

TBR=brettw@chromium.org,thakis@chromium.org,sdefresne@chromium.org,gab@chromi...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=722827
==========

to

==========
Revert of Enable DCHECKs by default in non-official builds. (patchset #3
id:40001 of https://codereview.chromium.org/2886803002/ )

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 472195 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...

Original issue's description:
> Enable DCHECKs by default in non-official builds.
> 
> BUG=722827
> TBR=sdefresne@chromium.org for ios/
> 
> Review-Url: https://codereview.chromium.org/2886803002
> Cr-Commit-Position: refs/heads/master@{#472195}
> Committed:
https://chromium.googlesource.com/chromium/src/+/875a2fa43caab0ee82efe68fb5ad...

TBR=brettw@chromium.org,thakis@chromium.org,sdefresne@chromium.org,gab@chromi...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=722827,723090,723049
==========

[dmazzoni, 2017-05-16 23:13:30]

The CQ bit was checked by dmazzoni@chromium.org

[commit-bot: I haz the power, 2017-05-16 23:14:10]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 23:15:00]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1494976410861510, "parent_rev":
"a8a710afa4d7e6c81a15f9fe73d562e8fb895fe9", "commit_rev":
"8cc767cb0d1c65af6d5a36858c9633c929b7e4cd"}

[commit-bot: I haz the power, 2017-05-16 23:15:24]

Description was changed from

==========
Revert of Enable DCHECKs by default in non-official builds. (patchset #3
id:40001 of https://codereview.chromium.org/2886803002/ )

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 472195 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...

Original issue's description:
> Enable DCHECKs by default in non-official builds.
> 
> BUG=722827
> TBR=sdefresne@chromium.org for ios/
> 
> Review-Url: https://codereview.chromium.org/2886803002
> Cr-Commit-Position: refs/heads/master@{#472195}
> Committed:
https://chromium.googlesource.com/chromium/src/+/875a2fa43caab0ee82efe68fb5ad...

TBR=brettw@chromium.org,thakis@chromium.org,sdefresne@chromium.org,gab@chromi...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=722827,723090,723049
==========

to

==========
Revert of Enable DCHECKs by default in non-official builds. (patchset #3
id:40001 of https://codereview.chromium.org/2886803002/ )

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 472195 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...

Original issue's description:
> Enable DCHECKs by default in non-official builds.
> 
> BUG=722827
> TBR=sdefresne@chromium.org for ios/
> 
> Review-Url: https://codereview.chromium.org/2886803002
> Cr-Commit-Position: refs/heads/master@{#472195}
> Committed:
https://chromium.googlesource.com/chromium/src/+/875a2fa43caab0ee82efe68fb5ad...

TBR=brettw@chromium.org,thakis@chromium.org,sdefresne@chromium.org,gab@chromi...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=722827,723090,723049

Review-Url: https://codereview.chromium.org/2892473002
Cr-Commit-Position: refs/heads/master@{#472242}
Committed:
https://chromium.googlesource.com/chromium/src/+/8cc767cb0d1c65af6d5a36858c96...
==========

[commit-bot: I haz the power, 2017-05-16 23:15:28]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8cc767cb0d1c65af6d5a36858c96...

[sdefresne, 2017-05-17 08:06:34]

lgtm

[gab, 2017-05-17 13:48:38]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2890783002/ by gab@chromium.org.

The reason for reverting is: Generating reland CL, won't land until identified
blockers have been fixed..