Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Unified Diff: ios/web/web_state/ui/wk_web_view_configuration_provider.mm

Issue 2892473002: Revert of Enable DCHECKs by default in non-official builds. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/dcheck_always_on.gni ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web/web_state/ui/wk_web_view_configuration_provider.mm
diff --git a/ios/web/web_state/ui/wk_web_view_configuration_provider.mm b/ios/web/web_state/ui/wk_web_view_configuration_provider.mm
index 7527133963eaf71a5d883e8b9da24a8d72e6df5a..e3386c5b0ad89d12ccc5f5c55095f40c906879fe 100644
--- a/ios/web/web_state/ui/wk_web_view_configuration_provider.mm
+++ b/ios/web/web_state/ui/wk_web_view_configuration_provider.mm
@@ -87,20 +87,18 @@
void WKWebViewConfigurationProvider::Purge() {
DCHECK([NSThread isMainThread]);
-#if DCHECK_IS_ON()
+#if !defined(NDEBUG) || !defined(DCHECK_ALWAYS_ON) // Matches DCHECK_IS_ON.
base::WeakNSObject<id> weak_configuration(configuration_);
base::WeakNSObject<id> weak_router(router_);
base::WeakNSObject<id> weak_process_pool([configuration_ processPool]);
-#endif // DCHECK_IS_ON()
+#endif // !defined(NDEBUG) || defined(DCHECK_ALWAYS_ON)
configuration_.reset();
router_.reset();
// Make sure that no one retains configuration, router, processPool.
-#if DCHECK_IS_ON()
DCHECK(!weak_configuration);
DCHECK(!weak_router);
// TODO(crbug.com/522672): Enable this DCHECK.
// DCHECK(!weak_process_pool);
-#endif // DCHECK_IS_ON()
}
} // namespace web
« no previous file with comments | « build/config/dcheck_always_on.gni ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698