Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 2892183002: reland "CrOS: Fix appearance of notification toasts when sliding out via gesture" (Closed)

Created:
3 years, 7 months ago by Evan Stade
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

reland "CrOS: Fix appearance of notification toasts when sliding out via gesture" This re-lands 3d7851ff607c370234e4f93ecf6 original review: https://codereview.chromium.org/2849523005 This converts SlideOutView to SlideOutController, which provides all the same functionality but can be added to any view rather than just those that extend it. It allows the target view to control the layer that's sliding out. For toasts, that is the widget's layer. For notifications inside the message center, that will continue to be the NotificationView itself. BUG=716429 Review-Url: https://codereview.chromium.org/2849523005 Review-Url: https://codereview.chromium.org/2855763003 Cr-Original-Commit-Position: refs/heads/master@{#468962} Review-Url: https://codereview.chromium.org/2892183002 . Cr-Commit-Position: refs/branch-heads/3071@{#630} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/dd91791606f52ac9b6d627b7ed3fe67ab52db50d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+194 lines, -339 lines) Patch
M ui/message_center/BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download
M ui/message_center/views/custom_notification_view_unittest.cc View 3 chunks +0 lines, -66 lines 0 comments Download
M ui/message_center/views/message_center_view_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/message_center/views/message_view.h View 7 chunks +18 lines, -10 lines 0 comments Download
M ui/message_center/views/message_view.cc View 7 chunks +15 lines, -13 lines 0 comments Download
M ui/message_center/views/message_view_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/message_center/views/notification_view_unittest.cc View 7 chunks +63 lines, -42 lines 0 comments Download
A ui/message_center/views/slide_out_controller.h View 1 chunk +61 lines, -0 lines 0 comments Download
A + ui/message_center/views/slide_out_controller.cc View 5 chunks +33 lines, -35 lines 0 comments Download
M ui/views/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D ui/views/controls/slide_out_view.h View 1 chunk +0 lines, -58 lines 0 comments Download
D ui/views/controls/slide_out_view.cc View 1 chunk +0 lines, -111 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Evan Stade
3 years, 7 months ago (2017-05-19 15:08:12 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
dd91791606f52ac9b6d627b7ed3fe67ab52db50d.

Powered by Google App Engine
This is Rietveld 408576698