reland "CrOS: Fix appearance of notification toasts when sliding out via gesture"

reland "CrOS: Fix appearance of notification toasts when sliding out via gesture"

This re-lands 3d7851ff607c370234e4f93ecf6
original review: https://codereview.chromium.org/2849523005

This converts SlideOutView to SlideOutController, which provides all the
same functionality but can be added to any view rather than just those
that extend it.

It allows the target view to control the layer that's sliding out. For
toasts, that is the widget's layer. For notifications inside the message
center, that will continue to be the NotificationView itself.

BUG=716429
Review-Url: https://codereview.chromium.org/2849523005

Review-Url: https://codereview.chromium.org/2855763003
Cr-Commit-Position: refs/heads/master@{#468962}
Committed: https://chromium.googlesource.com/chromium/src/+/d3c675e53e8b9c17d77e47107d04df8d0baae069

[Evan Stade, 2017-05-02 15:04:34]

Description was changed from

==========
Revert "Revert of CrOS: Fix appearance of notification toasts when sliding out
via gesture (patchset #4 id:60001 of https://codereview.chromium.org/2849523005/
)"

This reverts commit ba5c53c9efbb48cd5f54de19e996b24e63f511db.

BUG=
==========

to

==========
reland "CrOS: Fix appearance of notification toasts when sliding out via
gesture"

This re-lands 3d7851ff607c370234e4f93ecf6
original review: https://codereview.chromium.org/2849523005

This converts SlideOutView to SlideOutController, which provides all the
same functionality but can be added to any view rather than just those
that extend it.

It allows the target view to control the layer that's sliding out. For
toasts, that is the widget's layer. For notifications inside the message
center, that will continue to be the NotificationView itself.

BUG=716429
Review-Url: https://codereview.chromium.org/2849523005
==========

[Evan Stade, 2017-05-02 15:04:56]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[Evan Stade, 2017-05-02 15:05:16]

The CQ bit was unchecked by estade@chromium.org

[Evan Stade, 2017-05-02 15:05:33]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-02 15:06:22]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Evan Stade, 2017-05-02 15:59:59]

estade@chromium.org changed reviewers:
+ sky@chromium.org

[Evan Stade, 2017-05-02 16:00:00]

+sky, PTAL difference between PS1 and PS4.

Relevant trybot is win10_chromium_x64_rel_ng (not part of a default CQ run it
seems).

[commit-bot: I haz the power, 2017-05-02 17:06:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-02 17:06:38]

Dry run: This issue passed the CQ dry run.

[sky, 2017-05-03 04:45:52]

LGTM

[Evan Stade, 2017-05-03 14:22:05]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2017-05-03 14:22:21]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 14:27:39]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1493821325571420,
"parent_rev": "e3cfa1285898021bfe5bd4e62ddd94d0e97e6e93", "commit_rev":
"d3c675e53e8b9c17d77e47107d04df8d0baae069"}

[commit-bot: I haz the power, 2017-05-03 14:27:49]

Description was changed from

==========
reland "CrOS: Fix appearance of notification toasts when sliding out via
gesture"

This re-lands 3d7851ff607c370234e4f93ecf6
original review: https://codereview.chromium.org/2849523005

This converts SlideOutView to SlideOutController, which provides all the
same functionality but can be added to any view rather than just those
that extend it.

It allows the target view to control the layer that's sliding out. For
toasts, that is the widget's layer. For notifications inside the message
center, that will continue to be the NotificationView itself.

BUG=716429
Review-Url: https://codereview.chromium.org/2849523005
==========

to

==========
reland "CrOS: Fix appearance of notification toasts when sliding out via
gesture"

This re-lands 3d7851ff607c370234e4f93ecf6
original review: https://codereview.chromium.org/2849523005

This converts SlideOutView to SlideOutController, which provides all the
same functionality but can be added to any view rather than just those
that extend it.

It allows the target view to control the layer that's sliding out. For
toasts, that is the widget's layer. For notifications inside the message
center, that will continue to be the NotificationView itself.

BUG=716429
Review-Url: https://codereview.chromium.org/2849523005

Review-Url: https://codereview.chromium.org/2855763003
Cr-Commit-Position: refs/heads/master@{#468962}
Committed:
https://chromium.googlesource.com/chromium/src/+/d3c675e53e8b9c17d77e47107d04...
==========

[commit-bot: I haz the power, 2017-05-03 14:27:50]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/d3c675e53e8b9c17d77e47107d04...