Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issue 2892163003: Revert of Gate SK_FREETYPE_MINIMUM_RUNTIME_VERSION by use_system_freetype flag (Closed)

Created:
3 years, 7 months ago by Jamie Madill
Modified:
3 years, 7 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Gate SK_FREETYPE_MINIMUM_RUNTIME_VERSION by use_system_freetype flag (patchset #2 id:20001 of https://codereview.chromium.org/2876853004/ ) Reason for revert: This is causing a build failure on the Linux GPU FYI bots, likely because of a BUILD.gn error. First failing build: https://build.chromium.org/p/chromium.gpu.fyi/builders/GPU%20Linux%20Builder%20%28dbg%29/builds/81418 Error text: FAILED: gles2_conform_test_windowless python "../../build/toolchain/gcc_link_wrapper.py" --output="./gles2_conform_test_windowless" -- <snip> -lfreetype ./libskia.so: error: undefined reference to 'FT_Get_Var_Design_Coordinates' ./libskia.so: error: undefined reference to 'FT_Set_Default_Properties' Original issue's description: > Gate SK_FREETYPE_MINIMUM_RUNTIME_VERSION by use_system_freetype flag > > BUG=719345 > R=bungeman > > Review-Url: https://codereview.chromium.org/2876853004 > Cr-Commit-Position: refs/heads/master@{#473117} > Committed: https://chromium.googlesource.com/chromium/src/+/f677dc5c2d440d6e074a1d624e8a0b7a68371e08 TBR=bungeman@chromium.org,fmalita@chromium.org,reed@chromium.org,drott@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=719345 Review-Url: https://codereview.chromium.org/2892163003 Cr-Commit-Position: refs/heads/master@{#473181} Committed: https://chromium.googlesource.com/chromium/src/+/b68636d648c64b4312aa050486b74cccd6ceece4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M skia/BUILD.gn View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Jamie Madill
Created Revert of Gate SK_FREETYPE_MINIMUM_RUNTIME_VERSION by use_system_freetype flag
3 years, 7 months ago (2017-05-19 14:35:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2892163003/1
3 years, 7 months ago (2017-05-19 14:35:39 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-19 14:36:14 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b68636d648c64b4312aa050486b7...

Powered by Google App Engine
This is Rietveld 408576698