Update cc effect node documentation.

Update cc effect node documentation.

BUG=709137
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2892103002
Cr-Commit-Position: refs/heads/master@{#473106}
Committed: https://chromium.googlesource.com/chromium/src/+/678a39983b7553ebc6178e2ea44a1c10ccf330ba

[wkorman, 2017-05-18 23:17:17]

Description was changed from

==========
Update documentation and bit-pack effect node bools.

BUG=709137
==========

to

==========
Update documentation and bit-pack effect node bools.

BUG=709137
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[wkorman, 2017-05-18 23:23:14]

Description was changed from

==========
Update documentation and bit-pack effect node bools.

BUG=709137
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Update cc effect node documentation.

BUG=709137
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[wkorman, 2017-05-18 23:24:35]

wkorman@chromium.org changed reviewers:
+ enne@chromium.org, pdr@chromium.org

[wkorman, 2017-05-18 23:24:36]

Minor documentation while reading/scrutinizing effect node fields.

[pdr., 2017-05-18 23:52:47]

https://codereview.chromium.org/2892103002/diff/20001/cc/trees/effect_node.h
File cc/trees/effect_node.h (right):

https://codereview.chromium.org/2892103002/diff/20001/cc/trees/effect_node.h#...
cc/trees/effect_node.h:56: bool has_potential_filter_animation;
Is it just for this node, or this node or any ancestor node?

https://codereview.chromium.org/2892103002/diff/20001/cc/trees/effect_node.h#...
cc/trees/effect_node.h:64: // Whether this node's effect has been changed since
last
Nit: since [the] last frame.

[wkorman, 2017-05-18 23:57:03]

https://codereview.chromium.org/2892103002/diff/20001/cc/trees/effect_node.h
File cc/trees/effect_node.h (right):

https://codereview.chromium.org/2892103002/diff/20001/cc/trees/effect_node.h#...
cc/trees/effect_node.h:80: // TODO(wkorman): It appears the only reads of this
value are to
I found the one reference of impact -- RenderSurfaceImpl::MaskLayer uses this to
look up the layer by id. I must have missed in my previous searching. Will
remove this TODO.

[wkorman, 2017-05-19 00:37:04]

https://codereview.chromium.org/2892103002/diff/20001/cc/trees/effect_node.h
File cc/trees/effect_node.h (right):

https://codereview.chromium.org/2892103002/diff/20001/cc/trees/effect_node.h#...
cc/trees/effect_node.h:56: bool has_potential_filter_animation;
On 2017/05/18 23:52:47, pdr. wrote:
> Is it just for this node, or this node or any ancestor node?

Just this node.

https://codereview.chromium.org/2892103002/diff/20001/cc/trees/effect_node.h#...
cc/trees/effect_node.h:64: // Whether this node's effect has been changed since
last
On 2017/05/18 23:52:47, pdr. wrote:
> Nit: since [the] last frame.

Done.

[enne (OOO), 2017-05-19 00:49:40]

lgtm

[wkorman, 2017-05-19 04:50:17]

The CQ bit was checked by wkorman@chromium.org

[wkorman, 2017-05-19 04:50:18]

The patchset sent to the CQ was uploaded after l-g-t-m from enne@chromium.org
Link to the patchset: https://codereview.chromium.org/2892103002/#ps80001
(title: "Remove TODO.")

[commit-bot: I haz the power, 2017-05-19 04:50:54]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 06:23:11]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1495169417982580,
"parent_rev": "fd0e534843ac5926c1b26c7e1e7a7229fcb3aeee", "commit_rev":
"678a39983b7553ebc6178e2ea44a1c10ccf330ba"}

[commit-bot: I haz the power, 2017-05-19 06:23:31]

Description was changed from

==========
Update cc effect node documentation.

BUG=709137
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Update cc effect node documentation.

BUG=709137
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2892103002
Cr-Commit-Position: refs/heads/master@{#473106}
Committed:
https://chromium.googlesource.com/chromium/src/+/678a39983b7553ebc6178e2ea44a...
==========

[commit-bot: I haz the power, 2017-05-19 06:23:32]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/678a39983b7553ebc6178e2ea44a...