Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 2892023002: Revert of [csa] Add assertions to CSA (Closed)

Created:
3 years, 7 months ago by Michael Achenbach
Modified:
3 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [csa] Add assertions to CSA (patchset #11 id:200001 of https://codereview.chromium.org/2847923003/ ) Reason for revert: Seems to have made nosnap debug very slow and also leads to check failures: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%20debug/builds/13248 Original issue's description: > [csa] Add assertions to CSA > > This adds a bunch of assertions to CSA, mostly about documenting and checking > parameter types. > > Drive-by-change: Removed unused function. > > BUG=v8:6325 > > Review-Url: https://codereview.chromium.org/2847923003 > Cr-Commit-Position: refs/heads/master@{#45398} > Committed: https://chromium.googlesource.com/v8/v8/+/b14a981496ad1f841683479d2f9188dfa2d6b4bd TBR=cbruni@chromium.org,ishell@chromium.org,jgruber@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:6325 Review-Url: https://codereview.chromium.org/2892023002 Cr-Commit-Position: refs/heads/master@{#45401} Committed: https://chromium.googlesource.com/v8/v8/+/72edb7542562ffd6f50957681ecbc2f6fcd07f7a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -261 lines) Patch
M src/code-stub-assembler.h View 11 chunks +56 lines, -61 lines 0 comments Download
M src/code-stub-assembler.cc View 82 chunks +30 lines, -196 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Michael Achenbach
Created Revert of [csa] Add assertions to CSA
3 years, 7 months ago (2017-05-18 18:43:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2892023002/1
3 years, 7 months ago (2017-05-18 18:44:04 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-18 18:44:17 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/72edb7542562ffd6f50957681ecbc2f6fcd...

Powered by Google App Engine
This is Rietveld 408576698