Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2891973004: WIP Add memory optimisation option to ConsumeCommaSeparatedList (Closed)

Created:
3 years, 7 months ago by Bugs Nash
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews, blink-reviews-style_chromium.org, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

WIP Add memory optimisation option to ConsumeCommaSeparatedList BUG=668012

Patch Set 1 #

Patch Set 2 : fixed dcheck bug #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -16 lines) Patch
M third_party/WebKit/Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 1 2 chunks +18 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.h View 1 1 chunk +24 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (8 generated)
Bugs Nash
The CQ bit was checked by bugsnash@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-19 03:36:31 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2891973004/1
3 years, 7 months ago (2017-05-19 03:37:22 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-19 05:32:09 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/449473)
3 years, 7 months ago (2017-05-19 05:32:10 UTC) #4
Bugs Nash
The CQ bit was checked by bugsnash@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-22 02:50:55 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2891973004/20001
3 years, 7 months ago (2017-05-22 02:51:06 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-22 05:20:32 UTC) #7
commit-bot: I haz the power
3 years, 7 months ago (2017-05-22 05:20:33 UTC) #8 
Dry run: This issue passed the CQ dry run.

Powered by Google App Engine
This is Rietveld 408576698