WIP Add memory optimisation option to ConsumeCommaSeparatedList

third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/css/parser/CSSPropertyParser.h"
 
 #include <memory>
 #include "core/StylePropertyShorthand.h"
 #include "core/css/CSSBasicShapeValues.h"
 #include "core/css/CSSBorderImage.h"
@@ skipping 40 matching lines @@
 #include "core/css/properties/CSSPropertyShapeUtils.h"
 #include "core/css/properties/CSSPropertyWebkitBorderWidthUtils.h"
 #include "core/frame/UseCounter.h"
 #include "core/layout/LayoutTheme.h"
 #include "platform/wtf/text/StringBuilder.h"
 
 namespace blink {
 
 using namespace CSSPropertyParserHelpers;
 
+const bool kNoOptimisation = false;
+
 CSSPropertyParser::CSSPropertyParser(
     const CSSParserTokenRange& range,
     const CSSParserContext* context,
     HeapVector<CSSProperty, 256>* parsed_properties)
     : range_(range), context_(context), parsed_properties_(parsed_properties) {
   range_.ConsumeWhitespace();
 }
 
 void CSSPropertyParser::AddProperty(CSSPropertyID property,
                                     CSSPropertyID current_shorthand,
@@ skipping 1577 matching lines @@
       return CSSPropertyLengthUtils::ConsumeWidthOrHeight(range_, *context_);
     case CSSPropertyScrollSnapDestination:
     case CSSPropertyObjectPosition:
     case CSSPropertyPerspectiveOrigin:
       return ConsumePosition(range_, context_->Mode(), UnitlessQuirk::kForbid);
     case CSSPropertyWebkitHyphenateCharacter:
     case CSSPropertyWebkitLocale:
       return ConsumeLocale(range_);
     case CSSPropertyAnimationDelay:
     case CSSPropertyTransitionDelay:
-      return ConsumeCommaSeparatedList(ConsumeTime, range_, kValueRangeAll);
+      return ConsumeCommaSeparatedList(kNoOptimisation, ConsumeTime, range_,
+                                       kValueRangeAll);
     case CSSPropertyAnimationDirection:
       return ConsumeCommaSeparatedList(
+          kNoOptimisation,
           ConsumeIdent<CSSValueNormal, CSSValueAlternate, CSSValueReverse,
                        CSSValueAlternateReverse>,
           range_);
     case CSSPropertyAnimationDuration:
     case CSSPropertyTransitionDuration:
-      return ConsumeCommaSeparatedList(ConsumeTime, range_,
+      return ConsumeCommaSeparatedList(kNoOptimisation, ConsumeTime, range_,
                                        kValueRangeNonNegative);
     case CSSPropertyAnimationFillMode:
       return ConsumeCommaSeparatedList(
+          kNoOptimisation,
           ConsumeIdent<CSSValueNone, CSSValueForwards, CSSValueBackwards,
                        CSSValueBoth>,
           range_);
     case CSSPropertyAnimationIterationCount:
-      return ConsumeCommaSeparatedList(ConsumeAnimationIterationCount, range_);
+      return ConsumeCommaSeparatedList(kNoOptimisation,
+                                       ConsumeAnimationIterationCount, range_);
     case CSSPropertyAnimationName:
       return ConsumeCommaSeparatedList(
-          ConsumeAnimationName, range_, context_,
+          kNoOptimisation, ConsumeAnimationName, range_, context_,
           unresolved_property == CSSPropertyAliasWebkitAnimationName);
     case CSSPropertyAnimationPlayState:
       return ConsumeCommaSeparatedList(
-          ConsumeIdent<CSSValueRunning, CSSValuePaused>, range_);
+          kNoOptimisation, ConsumeIdent<CSSValueRunning, CSSValuePaused>,
+          range_);
     case CSSPropertyTransitionProperty: {
-      CSSValueList* list =
-          ConsumeCommaSeparatedList(ConsumeTransitionProperty, range_);
-      if (!list || !IsValidAnimationPropertyList(*list))
+      CSSValue* list = ConsumeCommaSeparatedList(
+          kNoOptimisation, ConsumeTransitionProperty, range_);
+      DCHECK(!list || list->IsBaseValueList());
+      if (!list || !IsValidAnimationPropertyList(*ToCSSValueList(list)))
         return nullptr;
       return list;
     }
     case CSSPropertyAnimationTimingFunction:
     case CSSPropertyTransitionTimingFunction:
-      return ConsumeCommaSeparatedList(ConsumeAnimationTimingFunction, range_);
+      return ConsumeCommaSeparatedList(kNoOptimisation,
+                                       ConsumeAnimationTimingFunction, range_);
     case CSSPropertyGridColumnGap:
     case CSSPropertyGridRowGap:
       return ConsumeLengthOrPercent(range_, context_->Mode(),
                                     kValueRangeNonNegative);
     case CSSPropertyColor:
     case CSSPropertyBackgroundColor:
       return ConsumeColor(range_, context_->Mode(), InQuirksMode());
     case CSSPropertyBorderBottomColor:
     case CSSPropertyBorderLeftColor:
     case CSSPropertyBorderRightColor:
@@ skipping 1709 matching lines @@
     case CSSPropertyPlaceItems:
       return ConsumePlaceItemsShorthand(important);
     case CSSPropertyPlaceSelf:
       return ConsumePlaceSelfShorthand(important);
     default:
       return false;
   }
 }
 
 }  // namespace blink