Ship and experiment with the Budget API

Ship and experiment with the Budget API

This CL enables the BudgetManager.reserve() method and activates the
Origin Trial for the BudgetManager.getBudget() and getCost() methods, in
accordance with the following Intents on blink-dev:

Intent to Ship: The Budget API’s reserve() method:
https://groups.google.com/a/chromium.org/d/topic/blink-dev/yBtmc-4xl_o/discussion

Intent to Experiment: The Budget API’s getCost() and getBudget() methods:
https://groups.google.com/a/chromium.org/d/topic/blink-dev/_l_fxUTWCHs/discussion

Feedback from the TAG has been received and responded to in the issues
kindly filed by Alex. This led to a number of clarifications and changes
in the specification, which are in line with Chrome's implementation.

TAG review:
https://github.com/w3ctag/design-reviews/issues/169
https://github.com/WICG/budget-api/issues?q=is%3Aissue%20tag

BUG=704725
Review-Url: https://codereview.chromium.org/2891953002
Cr-Commit-Position: refs/heads/master@{#474622}
Committed: https://chromium.googlesource.com/chromium/src/+/518fb6006595081fcaceabbd348a52155348fb58

[Peter Beverloo, 2017-05-18 15:41:23]

The CQ bit was checked by peter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-18 15:42:09]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 17:20:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-18 17:20:14]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Peter Beverloo, 2017-05-23 18:52:57]

The CQ bit was checked by peter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-23 18:53:41]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Peter Beverloo, 2017-05-23 18:53:58]

peter@chromium.org changed reviewers:
+ iclelland@chromium.org, johnme@chromium.org

[Peter Beverloo, 2017-05-23 18:53:58]

+Ian, John, PTAL!

I'll add an API OWNER for the stable changes once you're happy, as there's some
other things I need to follow up on too.

[commit-bot: I haz the power, 2017-05-23 21:29:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-23 21:29:07]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[johnme, 2017-05-24 12:08:44]

https://codereview.chromium.org/2891953002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/origin_trials/webexposed/budget-api-origin-trial-interfaces-expected.txt
(right):

https://codereview.chromium.org/2891953002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/origin_trials/webexposed/budget-api-origin-trial-interfaces-expected.txt:2:
FAIL Budget API related properties on interfaces in Origin-Trial enabled
document. assert_equals: Property getBudget exists on BudgetService expected
true but got false
Is this meant to fail?

https://codereview.chromium.org/2891953002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/origin_trials/webexposed/budget-api-origin-trial-interfaces-expected.txt:6:
FAIL Budget API related properties on interfaces in Origin-Trial enabled Service
Worker. assert_equals: Property getBudget exists on BudgetService expected true
but got false
Is this meant to fail?

https://codereview.chromium.org/2891953002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/budget/BudgetState.idl (right):

https://codereview.chromium.org/2891953002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/budget/BudgetState.idl:8:
OriginTrialEnabled=BudgetQuery,
Shouldn't it also be enabled by --enable-experimental-web-platform-features ?
Ditto for the getters in BudgetService.idl

https://codereview.chromium.org/2891953002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5 (right):

https://codereview.chromium.org/2891953002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5:126: status:
"stable",
Why didn't
third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt
change now that BudgetService is exposed as stable? It looks like you
accidentally wrote to the per-platform
third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt
instead.

[Peter Beverloo, 2017-05-24 14:35:23]

The CQ bit was checked by peter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-24 14:35:37]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Peter Beverloo, 2017-05-24 14:35:42]

Thanks John! PTAL

https://codereview.chromium.org/2891953002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/origin_trials/webexposed/budget-api-origin-trial-interfaces-expected.txt
(right):

https://codereview.chromium.org/2891953002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/origin_trials/webexposed/budget-api-origin-trial-interfaces-expected.txt:2:
FAIL Budget API related properties on interfaces in Origin-Trial enabled
document. assert_equals: Property getBudget exists on BudgetService expected
true but got false
On 2017/05/24 12:08:44, johnme wrote:
> Is this meant to fail?

Acknowledged.

https://codereview.chromium.org/2891953002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/origin_trials/webexposed/budget-api-origin-trial-interfaces-expected.txt:6:
FAIL Budget API related properties on interfaces in Origin-Trial enabled Service
Worker. assert_equals: Property getBudget exists on BudgetService expected true
but got false
On 2017/05/24 12:08:44, johnme wrote:
> Is this meant to fail?

No. Looks like --reset-results somehow wrote to the wrong file -- fixed!

https://codereview.chromium.org/2891953002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/budget/BudgetState.idl (right):

https://codereview.chromium.org/2891953002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/budget/BudgetState.idl:8:
OriginTrialEnabled=BudgetQuery,
On 2017/05/24 12:08:44, johnme wrote:
> Shouldn't it also be enabled by --enable-experimental-web-platform-features ?
> Ditto for the getters in BudgetService.idl

[RuntimeEnabled] is implied by [OriginTrialEnabled]. The BudgetQuery feature
still has been marked as experimental.

https://codereview.chromium.org/2891953002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5 (right):

https://codereview.chromium.org/2891953002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5:126: status:
"stable",
Because that file doesn't exist anymore.

[Peter Beverloo, 2017-05-24 14:42:23]

The CQ bit was checked by peter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-24 14:42:42]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[iclelland, 2017-05-24 15:26:37]

https://codereview.chromium.org/2891953002/diff/60001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/virtual/origin-trials-runtimeflags-disabled/http/tests/origin_trials/webexposed/budget-api-origin-trial-interfaces-expected.txt
(right):

https://codereview.chromium.org/2891953002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/virtual/origin-trials-runtimeflags-disabled/http/tests/origin_trials/webexposed/budget-api-origin-trial-interfaces-expected.txt:3:
PASS Budget API related interfaces in SW - no origin trial.
These two lines seem to indicate that the API is enabled in a service worker
even when the trial should be disabled from the command line. Is that true? I
don't see anything wrong with the integration code, so this might reflect a bug
in OT if it is.

[Peter Beverloo, 2017-05-24 15:31:25]

https://codereview.chromium.org/2891953002/diff/60001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/virtual/origin-trials-runtimeflags-disabled/http/tests/origin_trials/webexposed/budget-api-origin-trial-interfaces-expected.txt
(right):

https://codereview.chromium.org/2891953002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/virtual/origin-trials-runtimeflags-disabled/http/tests/origin_trials/webexposed/budget-api-origin-trial-interfaces-expected.txt:3:
PASS Budget API related interfaces in SW - no origin trial.
On 2017/05/24 15:26:37, iclelland wrote:
> These two lines seem to indicate that the API is enabled in a service worker
> even when the trial should be disabled from the command line. Is that true? I
> don't see anything wrong with the integration code, so this might reflect a
bug
> in OT if it is.

Isn't this just marking that the test file was ran successfully? The FAIL below
(line 5) represents this very case.

[iclelland, 2017-05-24 15:50:38]

LGTM

https://codereview.chromium.org/2891953002/diff/60001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/virtual/origin-trials-runtimeflags-disabled/http/tests/origin_trials/webexposed/budget-api-origin-trial-interfaces-expected.txt
(right):

https://codereview.chromium.org/2891953002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/virtual/origin-trials-runtimeflags-disabled/http/tests/origin_trials/webexposed/budget-api-origin-trial-interfaces-expected.txt:3:
PASS Budget API related interfaces in SW - no origin trial.
On 2017/05/24 15:31:25, Peter Beverloo wrote:
> On 2017/05/24 15:26:37, iclelland wrote:
> > These two lines seem to indicate that the API is enabled in a service worker
> > even when the trial should be disabled from the command line. Is that true?
I
> > don't see anything wrong with the integration code, so this might reflect a
> bug
> > in OT if it is.
> 
> Isn't this just marking that the test file was ran successfully? The FAIL
below
> (line 5) represents this very case.

That'll teach me to read the rest of the file more carefully :) I missed that,
thinking it was about other worker types.

[johnme, 2017-05-24 16:31:59]

lgtm

[commit-bot: I haz the power, 2017-05-24 18:42:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 18:42:07]

Dry run: This issue passed the CQ dry run.

[Peter Beverloo, 2017-05-24 19:43:45]

Description was changed from

==========
Ship and experiment with the Budget API

This CL enables the BudgetManager.reserve() method and activates the
Origin Trial for the BudgetManager.getBudget() and getCost() methods, in
accordance with the following Intents on blink-dev:

Intent to Ship: The Budget API’s reserve() method:
https://groups.google.com/a/chromium.org/d/topic/blink-dev/yBtmc-4xl_o/discus...

Intent to Experiment: The Budget API’s getCost() and getBudget() methods:
https://groups.google.com/a/chromium.org/d/topic/blink-dev/_l_fxUTWCHs/discus...

BUG=704725
==========

to

==========
Ship and experiment with the Budget API

This CL enables the BudgetManager.reserve() method and activates the
Origin Trial for the BudgetManager.getBudget() and getCost() methods, in
accordance with the following Intents on blink-dev:

Intent to Ship: The Budget API’s reserve() method:
https://groups.google.com/a/chromium.org/d/topic/blink-dev/yBtmc-4xl_o/discus...

Intent to Experiment: The Budget API’s getCost() and getBudget() methods:
https://groups.google.com/a/chromium.org/d/topic/blink-dev/_l_fxUTWCHs/discus...

Feedback from the TAG has been received and responded to in the issues
kindly filed by Alex. This led to a number of clarifications and changes
in the specification, which are in line with Chrome's implementation.

TAG review:
https://github.com/w3ctag/design-reviews/issues/169
https://github.com/WICG/budget-api/issues?q=is%3Aissue%20tag

BUG=704725
==========

[Peter Beverloo, 2017-05-24 19:59:42]

peter@chromium.org changed reviewers:
+ rbyers@chromium.org

[Peter Beverloo, 2017-05-24 19:59:43]

+rbyers for API OWNERS

See the description for the rationale :)

[Rick Byers, 2017-05-25 02:29:38]

webexposed LGTM (man it's annoying how many files need to change now)

[Peter Beverloo, 2017-05-25 11:00:21]

The CQ bit was checked by peter@chromium.org

[commit-bot: I haz the power, 2017-05-25 11:00:34]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 11:05:36]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1495710021724120,
"parent_rev": "08c4e3028cf0a15630a07874da6eec8694682ce4", "commit_rev":
"518fb6006595081fcaceabbd348a52155348fb58"}

[commit-bot: I haz the power, 2017-05-25 11:05:48]

Description was changed from

==========
Ship and experiment with the Budget API

This CL enables the BudgetManager.reserve() method and activates the
Origin Trial for the BudgetManager.getBudget() and getCost() methods, in
accordance with the following Intents on blink-dev:

Intent to Ship: The Budget API’s reserve() method:
https://groups.google.com/a/chromium.org/d/topic/blink-dev/yBtmc-4xl_o/discus...

Intent to Experiment: The Budget API’s getCost() and getBudget() methods:
https://groups.google.com/a/chromium.org/d/topic/blink-dev/_l_fxUTWCHs/discus...

Feedback from the TAG has been received and responded to in the issues
kindly filed by Alex. This led to a number of clarifications and changes
in the specification, which are in line with Chrome's implementation.

TAG review:
https://github.com/w3ctag/design-reviews/issues/169
https://github.com/WICG/budget-api/issues?q=is%3Aissue%20tag

BUG=704725
==========

to

==========
Ship and experiment with the Budget API

This CL enables the BudgetManager.reserve() method and activates the
Origin Trial for the BudgetManager.getBudget() and getCost() methods, in
accordance with the following Intents on blink-dev:

Intent to Ship: The Budget API’s reserve() method:
https://groups.google.com/a/chromium.org/d/topic/blink-dev/yBtmc-4xl_o/discus...

Intent to Experiment: The Budget API’s getCost() and getBudget() methods:
https://groups.google.com/a/chromium.org/d/topic/blink-dev/_l_fxUTWCHs/discus...

Feedback from the TAG has been received and responded to in the issues
kindly filed by Alex. This led to a number of clarifications and changes
in the specification, which are in line with Chrome's implementation.

TAG review:
https://github.com/w3ctag/design-reviews/issues/169
https://github.com/WICG/budget-api/issues?q=is%3Aissue%20tag

BUG=704725

Review-Url: https://codereview.chromium.org/2891953002
Cr-Commit-Position: refs/heads/master@{#474622}
Committed:
https://chromium.googlesource.com/chromium/src/+/518fb6006595081fcaceabbd348a...
==========

[commit-bot: I haz the power, 2017-05-25 11:05:52]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/518fb6006595081fcaceabbd348a...