third_party/WebKit/LayoutTests/virtual/origin-trials-runtimeflags-disabled/http/tests/origin_trials/webexposed/budget-api-origin-trial-interfaces-expected.txt - Issue 2891953002: Ship and experiment with the Budget API

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/virtual/origin-trials-runtimeflags-disabled/http/tests/origin_trials/webexposed/budget-api-origin-trial-interfaces-expected.txt

Issue 2891953002: Ship and experiment with the Budget API (Closed)

Patch Set: one more result file Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt ('k') | third_party/WebKit/LayoutTests/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 This is a testharness.js-based test.

	2 FAIL Budget API related properties on interfaces in Origin-Trial enabled documen t. assert_equals: Property getBudget exists on BudgetService expected true but g ot false

	3 PASS Budget API related interfaces in SW - no origin trial.
	iclelland 2017/05/24 15:26:37 These two lines seem to indicate that the API is e These two lines seem to indicate that the API is enabled in a service worker even when the trial should be disabled from the command line. Is that true? I don't see anything wrong with the integration code, so this might reflect a bug in OT if it is. Peter Beverloo 2017/05/24 15:31:25 Isn't this just marking that the test file was ran Show quoted text On 2017/05/24 15:26:37, iclelland wrote: > These two lines seem to indicate that the API is enabled in a service worker > even when the trial should be disabled from the command line. Is that true? I > don't see anything wrong with the integration code, so this might reflect a bug > in OT if it is. Isn't this just marking that the test file was ran successfully? The FAIL below (line 5) represents this very case. iclelland 2017/05/24 15:50:38 That'll teach me to read the rest of the file more Show quoted text On 2017/05/24 15:31:25, Peter Beverloo wrote: > On 2017/05/24 15:26:37, iclelland wrote: > > These two lines seem to indicate that the API is enabled in a service worker > > even when the trial should be disabled from the command line. Is that true? I > > don't see anything wrong with the integration code, so this might reflect a > bug > > in OT if it is. > > Isn't this just marking that the test file was ran successfully? The FAIL below > (line 5) represents this very case. That'll teach me to read the rest of the file more carefully :) I missed that, thinking it was about other worker types.
	4 PASS Budget API related interfaces in SW - origin trial enabled.

	5 FAIL Budget API related properties on interfaces in Origin-Trial regular Service Worker. assert_equals: Property getBudget exists on BudgetService expected true but got false

	6 FAIL Budget API related properties on interfaces in Origin-Trial enabled Service Worker. assert_equals: Property getBudget exists on BudgetService expected true but got false

	7 Harness: the test ran to completion.

	8

OLD	NEW