Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 2891893002: Fix Restore after Minimize on X11. (Closed)

Created:
3 years, 7 months ago by alshabalin
Modified:
3 years, 7 months ago
Reviewers:
msw, Elliot Glaysher
CC:
chromium-reviews, tfarina
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix Restore after Minimize on X11. BUG=723986 Review-Url: https://codereview.chromium.org/2891893002 Cr-Commit-Position: refs/heads/master@{#474211} Committed: https://chromium.googlesource.com/chromium/src/+/dd8019cfb439f7ebdc135820179f1cfc5c810b45

Patch Set 1 #

Total comments: 6

Patch Set 2 : Fix review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -1 line) Patch
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/widget_interactive_uitest.cc View 1 2 chunks +55 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
alshabalin
3 years, 7 months ago (2017-05-18 07:30:14 UTC) #3
Elliot Glaysher
lgtm
3 years, 7 months ago (2017-05-18 17:12:21 UTC) #4
msw
https://codereview.chromium.org/2891893002/diff/1/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc File ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc (right): https://codereview.chromium.org/2891893002/diff/1/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc#newcode571 ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc:571: if (!IsVisible() || !window_mapped_in_server_) I hope Elliot understands this ...
3 years, 7 months ago (2017-05-18 18:37:44 UTC) #5
alshabalin
https://codereview.chromium.org/2891893002/diff/1/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc File ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc (right): https://codereview.chromium.org/2891893002/diff/1/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc#newcode571 ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc:571: if (!IsVisible() || !window_mapped_in_server_) On 2017/05/18 18:37:44, msw wrote: ...
3 years, 7 months ago (2017-05-23 06:48:18 UTC) #6
msw
lgtm
3 years, 7 months ago (2017-05-23 16:50:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2891893002/20001
3 years, 7 months ago (2017-05-24 07:20:56 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-24 08:22:49 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/dd8019cfb439f7ebdc135820179f...

Powered by Google App Engine
This is Rietveld 408576698