Fix Restore after Minimize on X11.

ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/widget/desktop_aura/desktop_window_tree_host_x11.h"
 
 #include <X11/extensions/shape.h>
 #include <X11/extensions/XInput2.h>
 #include <X11/Xatom.h>
 #include <X11/Xregion.h>
@@ skipping 550 matching lines @@
 }
 
 aura::WindowTreeHost* DesktopWindowTreeHostX11::AsWindowTreeHost() {
   return this;
 }
 
 void DesktopWindowTreeHostX11::ShowWindowWithState(
     ui::WindowShowState show_state) {
   if (compositor())
     compositor()->SetVisible(true);
-  if (!IsVisible())
+  if (!IsVisible() || !window_mapped_in_server_)

[msw, 2017/05/18 18:37:44]

I hope Elliot understands this aspect of the CL, I don't!

[alshabalin, 2017/05/23 06:48:18]

The problem was: during minimization some WMs (e.g. openbox) unmap the window
(which sets window_mapped_in_server_ to false). Now, when we call
Widget::Restore, we need to map the window back but at that moment
Widget::IsVisible() is true (because window_mapped_in_client_ is true).

I decided to go for this solution instead of modifying window_mapped_in_client_
during minimization, because asking to map window seems to makes sense when
either of window_mapped_in_* is false.

     MapWindow(show_state);
 
   switch (show_state) {
     case ui::SHOW_STATE_MAXIMIZED:
       Maximize();
       break;
     case ui::SHOW_STATE_MINIMIZED:
       Minimize();
       break;
     case ui::SHOW_STATE_FULLSCREEN:
@@ skipping 1774 matching lines @@
 
 // static
 DesktopWindowTreeHost* DesktopWindowTreeHost::Create(
     internal::NativeWidgetDelegate* native_widget_delegate,
     DesktopNativeWidgetAura* desktop_native_widget_aura) {
   return new DesktopWindowTreeHostX11(native_widget_delegate,
                                       desktop_native_widget_aura);
 }
 
 }  // namespace views