Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2523)

Unified Diff: build/toolchain/linux/BUILD.gn

Issue 2891843002: build: Remove build system support for gold plugin, except under ChromeOS. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/toolchain/linux/BUILD.gn
diff --git a/build/toolchain/linux/BUILD.gn b/build/toolchain/linux/BUILD.gn
index 5b7689f9f2d31f796a990252e16430fb3d08ad12..a6d790e777c65212e286fae7e0645294ab096cd6 100644
--- a/build/toolchain/linux/BUILD.gn
+++ b/build/toolchain/linux/BUILD.gn
@@ -2,6 +2,7 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
+import("//build/config/compiler/compiler.gni")
import("//build/config/sysroot.gni")
import("//build/toolchain/gcc_toolchain.gni")
@@ -59,7 +60,9 @@ gcc_toolchain("arm") {
clang_toolchain("clang_x86") {
# Output linker map files for binary size analysis.
- enable_linker_map = true
+ # Currently disabled on LLD because of a bug (fixed upstream).
+ # See https://crbug.com/716209.
+ enable_linker_map = !use_lld
toolchain_args = {
current_cpu = "x86"
@@ -93,7 +96,9 @@ gcc_toolchain("x86") {
ld = cxx
# Output linker map files for binary size analysis.
- enable_linker_map = true
+ # Currently disabled on LLD because of a bug (fixed upstream).
+ # See https://crbug.com/716209.
+ enable_linker_map = !use_lld
toolchain_args = {
current_cpu = "x86"
@@ -104,7 +109,9 @@ gcc_toolchain("x86") {
clang_toolchain("clang_x64") {
# Output linker map files for binary size analysis.
- enable_linker_map = true
+ # Currently disabled on LLD because of a bug (fixed upstream).
+ # See https://crbug.com/716209.
+ enable_linker_map = !use_lld
toolchain_args = {
current_cpu = "x64"
@@ -138,7 +145,9 @@ gcc_toolchain("x64") {
ld = cxx
# Output linker map files for binary size analysis.
- enable_linker_map = true
+ # Currently disabled on LLD because of a bug (fixed upstream).
+ # See https://crbug.com/716209.
+ enable_linker_map = !use_lld
toolchain_args = {
current_cpu = "x64"

Powered by Google App Engine
This is Rietveld 408576698