build/toolchain/gcc_toolchain.gni - Issue 2891843002: build: Remove build system support for gold plugin, except under ChromeOS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/toolchain/gcc_toolchain.gni

Issue 2891843002: build: Remove build system support for gold plugin, except under ChromeOS. (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/toolchain/gcc_toolchain.gni

diff --git a/build/toolchain/gcc_toolchain.gni b/build/toolchain/gcc_toolchain.gni

index fa0de63052aeae948fca9aa10f020d63db87bd9b..ed42ec22e640b973a93b51c3959d289a378fc644 100644

--- a/build/toolchain/gcc_toolchain.gni

+++ b/build/toolchain/gcc_toolchain.gni

@@ -254,10 +254,8 @@ template("gcc_toolchain") {

extra_ldflags = ""

}

- # Currently disabled on LLD because of a bug (fixed upstream).

- # See https://crbug.com/716209.

enable_linker_map = defined(invoker.enable_linker_map) &&

- invoker.enable_linker_map && !use_lld

+ invoker.enable_linker_map

# These library switches can apply to all tools below.

lib_switch = "-l"