Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Unified Diff: runtime/vm/flow_graph_compiler_arm.cc

Issue 2891713002: Cleanup: Make CheckClassId instruction more general so it (Closed)
Patch Set: Feedback from Martin Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/constants_dbc.h ('k') | runtime/vm/flow_graph_compiler_arm64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_compiler_arm.cc
diff --git a/runtime/vm/flow_graph_compiler_arm.cc b/runtime/vm/flow_graph_compiler_arm.cc
index b1238061532e708f9cdf546a5f19814437109c32..fdf3257f57a6db6bc91cb598785d9f82ad546fe3 100644
--- a/runtime/vm/flow_graph_compiler_arm.cc
+++ b/runtime/vm/flow_graph_compiler_arm.cc
@@ -1523,13 +1523,13 @@ int FlowGraphCompiler::EmitTestAndCallCheckCid(Label* next_label,
int bias) {
intptr_t cid_start = range.cid_start;
intptr_t cid_end = range.cid_end;
- if (cid_start == cid_end) {
+ if (range.IsSingleCid()) {
__ CompareImmediate(R2, cid_start - bias);
__ b(next_label, NE);
} else {
__ AddImmediate(R2, R2, bias - cid_start);
bias = cid_start;
- __ CompareImmediate(R2, cid_end - cid_start);
+ __ CompareImmediate(R2, range.Extent());
__ b(next_label, HI); // Unsigned higher.
}
return bias;
« no previous file with comments | « runtime/vm/constants_dbc.h ('k') | runtime/vm/flow_graph_compiler_arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698