Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Side by Side Diff: runtime/vm/flow_graph_compiler_arm.cc

Issue 2891713002: Cleanup: Make CheckClassId instruction more general so it (Closed)
Patch Set: Feedback from Martin Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/constants_dbc.h ('k') | runtime/vm/flow_graph_compiler_arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM.
6 #if defined(TARGET_ARCH_ARM) 6 #if defined(TARGET_ARCH_ARM)
7 7
8 #include "vm/flow_graph_compiler.h" 8 #include "vm/flow_graph_compiler.h"
9 9
10 #include "vm/ast_printer.h" 10 #include "vm/ast_printer.h"
(...skipping 1505 matching lines...) Expand 10 before | Expand all | Expand 10 after
1516 void FlowGraphCompiler::EmitTestAndCallLoadCid() { 1516 void FlowGraphCompiler::EmitTestAndCallLoadCid() {
1517 __ LoadClassId(R2, R0); 1517 __ LoadClassId(R2, R0);
1518 } 1518 }
1519 1519
1520 1520
1521 int FlowGraphCompiler::EmitTestAndCallCheckCid(Label* next_label, 1521 int FlowGraphCompiler::EmitTestAndCallCheckCid(Label* next_label,
1522 const CidRange& range, 1522 const CidRange& range,
1523 int bias) { 1523 int bias) {
1524 intptr_t cid_start = range.cid_start; 1524 intptr_t cid_start = range.cid_start;
1525 intptr_t cid_end = range.cid_end; 1525 intptr_t cid_end = range.cid_end;
1526 if (cid_start == cid_end) { 1526 if (range.IsSingleCid()) {
1527 __ CompareImmediate(R2, cid_start - bias); 1527 __ CompareImmediate(R2, cid_start - bias);
1528 __ b(next_label, NE); 1528 __ b(next_label, NE);
1529 } else { 1529 } else {
1530 __ AddImmediate(R2, R2, bias - cid_start); 1530 __ AddImmediate(R2, R2, bias - cid_start);
1531 bias = cid_start; 1531 bias = cid_start;
1532 __ CompareImmediate(R2, cid_end - cid_start); 1532 __ CompareImmediate(R2, range.Extent());
1533 __ b(next_label, HI); // Unsigned higher. 1533 __ b(next_label, HI); // Unsigned higher.
1534 } 1534 }
1535 return bias; 1535 return bias;
1536 } 1536 }
1537 1537
1538 1538
1539 #undef __ 1539 #undef __
1540 #define __ compiler_->assembler()-> 1540 #define __ compiler_->assembler()->
1541 1541
1542 1542
(...skipping 285 matching lines...) Expand 10 before | Expand all | Expand 10 after
1828 DRegister dreg = EvenDRegisterOf(reg); 1828 DRegister dreg = EvenDRegisterOf(reg);
1829 __ vldrd(dreg, Address(SP, kDoubleSize, Address::PostIndex)); 1829 __ vldrd(dreg, Address(SP, kDoubleSize, Address::PostIndex));
1830 } 1830 }
1831 1831
1832 1832
1833 #undef __ 1833 #undef __
1834 1834
1835 } // namespace dart 1835 } // namespace dart
1836 1836
1837 #endif // defined TARGET_ARCH_ARM 1837 #endif // defined TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « runtime/vm/constants_dbc.h ('k') | runtime/vm/flow_graph_compiler_arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698