Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1419)

Unified Diff: runtime/vm/constants_dbc.h

Issue 2891713002: Cleanup: Make CheckClassId instruction more general so it (Closed)
Patch Set: Feedback from Martin Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/flow_graph_compiler_arm.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/constants_dbc.h
diff --git a/runtime/vm/constants_dbc.h b/runtime/vm/constants_dbc.h
index becbe0335dd4b738b31b12e90f5268c5eb7337a3..5e843617e9108132ef7dcc691f04c2f9eec9acac 100644
--- a/runtime/vm/constants_dbc.h
+++ b/runtime/vm/constants_dbc.h
@@ -590,6 +590,12 @@ namespace dart {
// If the class id in FP[rA] matches the class id D, then skip the
// following instruction.
//
+// - CheckClassIdRange rA, D
+//
+// Next instruction is a Nop with S, the size of the class-id range.
+// If the class id in FP[rA] is between the D D + S, then skip the
+// following instruction.
+//
// - CheckBitTest rA, D
//
// Skips the next 3 instructions if the object at FP[rA] is a valid class for
@@ -841,6 +847,7 @@ namespace dart {
V(CheckSmi, A, reg, ___, ___) \
V(CheckEitherNonSmi, A_D, reg, reg, ___) \
V(CheckClassId, A_D, reg, num, ___) \
+ V(CheckClassIdRange, A_D, reg, num, ___) \
V(CheckBitTest, A_D, reg, num, ___) \
V(CheckCids, A_B_C, reg, num, num) \
V(CheckCidsByRange, A_B_C, reg, num, num) \
« no previous file with comments | « no previous file | runtime/vm/flow_graph_compiler_arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698