components/omnibox/browser/omnibox_edit_unittest.cc - Issue 2891653003: [omnibox] Break out SetCaretPos() method and enhance browser test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/omnibox/browser/omnibox_edit_unittest.cc

Issue 2891653003: [omnibox] Break out SetCaretPos() method and enhance browser test (Closed)

Patch Set: Fixed range on Cocoa Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/omnibox/browser/omnibox_edit_unittest.cc

diff --git a/components/omnibox/browser/omnibox_edit_unittest.cc b/components/omnibox/browser/omnibox_edit_unittest.cc

index b216370fd968c10b20fe56142d6b70c54c6f976a..c44e69bdf6b11a7bd98b8f6ae0a6a815965911b5 100644

--- a/components/omnibox/browser/omnibox_edit_unittest.cc

+++ b/components/omnibox/browser/omnibox_edit_unittest.cc

@@ -49,6 +49,7 @@ class TestingOmniboxView : public OmniboxView {

bool notify_text_changed) override {

text_ = text;

}

+ void SetCaretPos(size_t caret_pos) override {}

void EnterKeywordModeForDefaultSearchProvider() override {}

bool IsSelectAll() const override { return false; }

bool DeleteAtEndPressed() override { return false; }