Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1091)

Unified Diff: components/omnibox/browser/omnibox_view.h

Issue 2891653003: [omnibox] Break out SetCaretPos() method and enhance browser test (Closed)
Patch Set: Fixed range on Cocoa Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/omnibox/browser/omnibox_view.h
diff --git a/components/omnibox/browser/omnibox_view.h b/components/omnibox/browser/omnibox_view.h
index c764782ec848d5832725252bd5aafe27193b13b4..03d358c67cb42c70902146d182cf2634559249b4 100644
--- a/components/omnibox/browser/omnibox_view.h
+++ b/components/omnibox/browser/omnibox_view.h
@@ -104,6 +104,10 @@ class OmniboxView {
bool update_popup,
bool notify_text_changed) = 0;
+ // Sets the caret position. Removes any selection. Clamps the requested caret
+ // position to the length of the current text.
+ virtual void SetCaretPos(size_t caret_pos) = 0;
+
// Transitions the user into keyword mode with their default search provider,
// preserving and selecting the user's text if they already typed in a query.
virtual void EnterKeywordModeForDefaultSearchProvider() = 0;
« no previous file with comments | « components/omnibox/browser/omnibox_edit_unittest.cc ('k') | ios/chrome/browser/ui/omnibox/omnibox_view_ios.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698