Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Side by Side Diff: components/omnibox/browser/omnibox_edit_unittest.cc

Issue 2891653003: [omnibox] Break out SetCaretPos() method and enhance browser test (Closed)
Patch Set: Fixed range on Cocoa Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stddef.h> 5 #include <stddef.h>
6 6
7 #include "base/macros.h" 7 #include "base/macros.h"
8 #include "base/memory/ptr_util.h" 8 #include "base/memory/ptr_util.h"
9 #include "base/message_loop/message_loop.h" 9 #include "base/message_loop/message_loop.h"
10 #include "base/strings/utf_string_conversions.h" 10 #include "base/strings/utf_string_conversions.h"
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
42 void SetUserText(const base::string16& text, 42 void SetUserText(const base::string16& text,
43 bool update_popup) override { 43 bool update_popup) override {
44 text_ = text; 44 text_ = text;
45 } 45 }
46 void SetWindowTextAndCaretPos(const base::string16& text, 46 void SetWindowTextAndCaretPos(const base::string16& text,
47 size_t caret_pos, 47 size_t caret_pos,
48 bool update_popup, 48 bool update_popup,
49 bool notify_text_changed) override { 49 bool notify_text_changed) override {
50 text_ = text; 50 text_ = text;
51 } 51 }
52 void SetCaretPos(size_t caret_pos) override {}
52 void EnterKeywordModeForDefaultSearchProvider() override {} 53 void EnterKeywordModeForDefaultSearchProvider() override {}
53 bool IsSelectAll() const override { return false; } 54 bool IsSelectAll() const override { return false; }
54 bool DeleteAtEndPressed() override { return false; } 55 bool DeleteAtEndPressed() override { return false; }
55 void GetSelectionBounds(size_t* start, size_t* end) const override {} 56 void GetSelectionBounds(size_t* start, size_t* end) const override {}
56 void SelectAll(bool reversed) override {} 57 void SelectAll(bool reversed) override {}
57 void RevertAll() override {} 58 void RevertAll() override {}
58 void UpdatePopup() override {} 59 void UpdatePopup() override {}
59 void SetFocus() override {} 60 void SetFocus() override {}
60 void ApplyCaretVisibility() override {} 61 void ApplyCaretVisibility() override {}
61 void OnTemporaryTextMaybeChanged(const base::string16& display_text, 62 void OnTemporaryTextMaybeChanged(const base::string16& display_text,
(...skipping 279 matching lines...) Expand 10 before | Expand all | Expand 10 after
341 alternate_nav_url, base::string16(), 0); 342 alternate_nav_url, base::string16(), 0);
342 EXPECT_TRUE(AutocompleteInput::HasHTTPScheme( 343 EXPECT_TRUE(AutocompleteInput::HasHTTPScheme(
343 client->alternate_nav_match().fill_into_edit)); 344 client->alternate_nav_match().fill_into_edit));
344 345
345 model()->SetUserText(base::ASCIIToUTF16("abcd")); 346 model()->SetUserText(base::ASCIIToUTF16("abcd"));
346 model()->OpenMatch(match, WindowOpenDisposition::CURRENT_TAB, 347 model()->OpenMatch(match, WindowOpenDisposition::CURRENT_TAB,
347 alternate_nav_url, base::string16(), 0); 348 alternate_nav_url, base::string16(), 0);
348 EXPECT_TRUE(AutocompleteInput::HasHTTPScheme( 349 EXPECT_TRUE(AutocompleteInput::HasHTTPScheme(
349 client->alternate_nav_match().fill_into_edit)); 350 client->alternate_nav_match().fill_into_edit));
350 } 351 }
OLDNEW
« no previous file with comments | « components/omnibox/browser/omnibox_edit_model.cc ('k') | components/omnibox/browser/omnibox_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698