Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 2891563003: [ObjC ARC] Converts ios/chrome/browser/ui/ntp:ntp_header to ARC. (Closed)

Created:
3 years, 7 months ago by stkhapugin
Modified:
3 years, 6 months ago
Reviewers:
sdefresne
CC:
chromium-reviews, marq+watch_chromium.org, ios-reviews+chrome_chromium.org, noyau+watch_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), gambard
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/ui/ntp:ntp_header to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2891563003 Cr-Commit-Position: refs/heads/master@{#475921} Committed: https://chromium.googlesource.com/chromium/src/+/b2e9fa65e11315261f70f72d83af61c6bf9f6875

Patch Set 1 #

Total comments: 2

Patch Set 2 : comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -37 lines) Patch
M ios/chrome/browser/ui/ntp/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/ntp/new_tab_page_header_constants.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/ntp/new_tab_page_header_view.mm View 7 chunks +12 lines, -12 lines 0 comments Download
M ios/chrome/browser/ui/ntp/new_tab_page_toolbar_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/ntp/new_tab_page_toolbar_controller.mm View 8 chunks +27 lines, -24 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 22 (15 generated)
stkhapugin
PTAL gambard FYI
3 years, 7 months ago (2017-05-17 14:01:02 UTC) #4
sdefresne
lgtm https://codereview.chromium.org/2891563003/diff/1/ios/chrome/browser/ui/ntp/new_tab_page_header_view.h File ios/chrome/browser/ui/ntp/new_tab_page_header_view.h (right): https://codereview.chromium.org/2891563003/diff/1/ios/chrome/browser/ui/ntp/new_tab_page_header_view.h#newcode20 ios/chrome/browser/ui/ntp/new_tab_page_header_view.h:20: @property(weak, nonatomic, readonly) UIView* toolBarView; Revert, the property ...
3 years, 7 months ago (2017-05-17 16:27:11 UTC) #7
stkhapugin
Thanks! https://codereview.chromium.org/2891563003/diff/1/ios/chrome/browser/ui/ntp/new_tab_page_header_view.h File ios/chrome/browser/ui/ntp/new_tab_page_header_view.h (right): https://codereview.chromium.org/2891563003/diff/1/ios/chrome/browser/ui/ntp/new_tab_page_header_view.h#newcode20 ios/chrome/browser/ui/ntp/new_tab_page_header_view.h:20: @property(weak, nonatomic, readonly) UIView* toolBarView; On 2017/05/17 16:27:11, ...
3 years, 6 months ago (2017-05-30 18:22:42 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2891563003/20001
3 years, 6 months ago (2017-05-30 18:23:49 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/306168)
3 years, 6 months ago (2017-05-30 19:33:16 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2891563003/20001
3 years, 6 months ago (2017-05-31 15:00:30 UTC) #19
commit-bot: I haz the power
3 years, 6 months ago (2017-05-31 15:47:11 UTC) #22
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b2e9fa65e11315261f70f72d83af...

Powered by Google App Engine
This is Rietveld 408576698