Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2889963002: [ObjC ARC] Converts ios/chrome/browser/ui/ntp:ntp_internal to ARC.

Created:
3 years, 7 months ago by stkhapugin
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews, marq+watch_chromium.org, ios-reviews+chrome_chromium.org, noyau+watch_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/ui/ntp:ntp_internal to ARC. Automatically generated ARCMigrate commit Notable issues: * Some unit tests were accessing ivars previously declared in a header. Those accessors were moved to the implementation file, and a _testing header was created. BUG=624363 TEST=None

Patch Set 1 #

Patch Set 2 : Fixes ivars in a header and some cleanup #

Patch Set 3 : Moved testing method accessing ivars to a category #

Unified diffs Side-by-side diffs Delta from patch set Stats (+375 lines, -383 lines) Patch
M ios/chrome/browser/ui/ntp/BUILD.gn View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/ntp/centering_scrollview.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/ntp/google_landing_mediator.mm View 1 2 7 chunks +12 lines, -11 lines 0 comments Download
M ios/chrome/browser/ui/ntp/google_landing_view_controller.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/ntp/google_landing_view_controller.mm View 23 chunks +76 lines, -80 lines 0 comments Download
M ios/chrome/browser/ui/ntp/incognito_panel_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/ntp/incognito_panel_controller.mm View 12 chunks +68 lines, -68 lines 0 comments Download
M ios/chrome/browser/ui/ntp/most_visited_cell.mm View 8 chunks +16 lines, -14 lines 0 comments Download
M ios/chrome/browser/ui/ntp/most_visited_layout.mm View 1 chunk +6 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/ntp/new_tab_page_bar.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ios/chrome/browser/ui/ntp/new_tab_page_bar.mm View 1 9 chunks +19 lines, -20 lines 0 comments Download
M ios/chrome/browser/ui/ntp/new_tab_page_bar_button.mm View 1 3 chunks +13 lines, -23 lines 0 comments Download
M ios/chrome/browser/ui/ntp/new_tab_page_bar_item.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/ntp/new_tab_page_bar_item.mm View 1 2 chunks +9 lines, -26 lines 0 comments Download
M ios/chrome/browser/ui/ntp/new_tab_page_controller.h View 1 1 chunk +2 lines, -9 lines 0 comments Download
M ios/chrome/browser/ui/ntp/new_tab_page_controller.mm View 1 2 14 chunks +75 lines, -53 lines 0 comments Download
A ios/chrome/browser/ui/ntp/new_tab_page_controller_testing.h View 1 2 1 chunk +20 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/ntp/new_tab_page_controller_unittest.mm View 1 2 2 chunks +1 line, -26 lines 0 comments Download
M ios/chrome/browser/ui/ntp/new_tab_page_egtest.mm View 1 2 2 chunks +1 line, -6 lines 0 comments Download
M ios/chrome/browser/ui/ntp/new_tab_page_panel_protocol.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/ntp/new_tab_page_panel_protocol.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/ntp/new_tab_page_view.mm View 2 chunks +6 lines, -7 lines 0 comments Download
M ios/chrome/browser/ui/ntp/notification_promo_whats_new.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/ntp/whats_new_header_view.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/ntp/whats_new_header_view.mm View 8 chunks +26 lines, -27 lines 0 comments Download

Depends on Patchset:

Issue 2891563003 Patch 20001

Messages

Total messages: 15 (15 generated)
stkhapugin
The CQ bit was checked by stkhapugin@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-17 13:28:00 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2889963002/1
3 years, 7 months ago (2017-05-17 13:28:17 UTC) #2
stkhapugin
The CQ bit was checked by stkhapugin@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-17 15:43:07 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2889963002/20001
3 years, 7 months ago (2017-05-17 15:43:45 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-17 15:53:59 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-clang/builds/98104) ios-simulator on ...
3 years, 7 months ago (2017-05-17 15:54:00 UTC) #6
stkhapugin
The CQ bit was checked by stkhapugin@chromium.org to run a CQ dry run
3 years, 6 months ago (2017-05-31 15:49:05 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2889963002/40001
3 years, 6 months ago (2017-05-31 15:49:25 UTC) #8
stkhapugin
Description was changed from ========== [ObjC ARC] Converts ios/chrome/browser/ui/ntp:ntp_internal to ARC. Automatically generated ARCMigrate commit ...
3 years, 6 months ago (2017-05-31 15:49:53 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 6 months ago (2017-05-31 17:16:31 UTC) #10
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/227379)
3 years, 6 months ago (2017-05-31 17:16:32 UTC) #11
stkhapugin
The CQ bit was checked by stkhapugin@chromium.org to run a CQ dry run
3 years, 6 months ago (2017-06-20 14:49:12 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2889963002/40001
3 years, 6 months ago (2017-06-20 14:49:25 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 6 months ago (2017-06-20 14:51:57 UTC) #14
commit-bot: I haz the power
3 years, 6 months ago (2017-06-20 14:51:58 UTC) #15 
Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

Powered by Google App Engine
This is Rietveld 408576698