components/cronet/tools/cr_cronet.py - Issue 2891533002: [Cronet] Use is_official_build=true for Cronet builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/tools/cr_cronet.py

Issue 2891533002: [Cronet] Use is_official_build=true for Cronet builds. (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/cronet/tools/cr_cronet.py

diff --git a/components/cronet/tools/cr_cronet.py b/components/cronet/tools/cr_cronet.py

index 49a58a6c655af33ae6039a2c12f5ca795b2d0b64..9698e54a946a1f8f3044dff585e41bc9d83fda86 100755

--- a/components/cronet/tools/cr_cronet.py

+++ b/components/cronet/tools/cr_cronet.py

@@ -95,7 +95,7 @@ def main():

else:

target_os = 'android'

test_target = 'cronet_test_instrumentation_apk'

- gn_args = 'use_errorprone_java_compiler=true arm_use_neon=false '

+ gn_args = 'is_official_build=true use_errorprone_java_compiler=true arm_use_neon=false '

mgersh 2017/05/16 21:22:55 Should this be only on release builds?

mef 2017/05/17 16:01:14 Done.

gn_extra = ''

out_dir_suffix = ''

« no previous file with comments | « no previous file | tools/mb/mb_config.pyl » ('j') | tools/mb/mb_config.pyl » ('J')