tools/mb/mb_config.pyl - Issue 2891533002: [Cronet] Use is_official_build=true for Cronet builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/mb/mb_config.pyl

Issue 2891533002: [Cronet] Use is_official_build=true for Cronet builds. (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/mb/mb_config.pyl

diff --git a/tools/mb/mb_config.pyl b/tools/mb/mb_config.pyl

index a17e5f4ef8b38dbd515c5b7996ea7589a297ce38..ff6a9e57b4e32521c06550a15a96dbde3d67c4a4 100644

--- a/tools/mb/mb_config.pyl

+++ b/tools/mb/mb_config.pyl

@@ -735,27 +735,27 @@

'android_cronet_release_bot_minimal_symbols_arm64': [

- 'android', 'cronet', 'release_bot', 'minimal_symbols', 'arm64',

+ 'android', 'cronet', 'official_optimize', 'release_bot', 'minimal_symbols', 'arm64',

jbudorick 2017/05/16 22:00:42 official_optimize and not official?

mef 2017/05/17 16:01:14 Hrm, good question. What does is_chrome_branded=tr

'android_cronet_release_bot_minimal_symbols_armv6': [

- 'android', 'cronet', 'release_bot', 'minimal_symbols', 'armv6',

+ 'android', 'cronet', 'official_optimize', 'release_bot', 'minimal_symbols', 'armv6',

'android_cronet_release_bot_minimal_symbols_arm_no_neon': [

- 'android', 'cronet', 'release_bot', 'minimal_symbols', 'arm_no_neon',

+ 'android', 'cronet', 'official_optimize', 'release_bot', 'minimal_symbols', 'arm_no_neon',

'android_cronet_release_bot_minimal_symbols_arm_no_neon_clang_asan': [

- 'android', 'cronet', 'release_bot', 'minimal_symbols', 'arm_no_neon', 'clang', 'asan',

+ 'android', 'cronet', 'official_optimize', 'release_bot', 'minimal_symbols', 'arm_no_neon', 'clang', 'asan',

'android_cronet_release_bot_minimal_symbols_mipsel': [

- 'android', 'cronet', 'release_bot', 'minimal_symbols', 'mipsel',

+ 'android', 'cronet', 'official_optimize', 'release_bot', 'minimal_symbols', 'mipsel',

'android_cronet_release_bot_minimal_symbols_x86': [

- 'android', 'cronet', 'release_bot', 'minimal_symbols', 'x86',

+ 'android', 'cronet', 'official_optimize', 'release_bot', 'minimal_symbols', 'x86',

'android_cronet_release_trybot_arm_no_neon': [