Chromium Code Reviews Chromium Code Reviews
Issue 2891533002:
[Cronet] Use is_official_build=true for Cronet builds. (Closed)
| OLD | NEW |
|---|---|
| 1 #!/usr/bin/python | 1 #!/usr/bin/python |
| 2 # Copyright 2014 The Chromium Authors. All rights reserved. | 2 # Copyright 2014 The Chromium Authors. All rights reserved. |
| 3 # Use of this source code is governed by a BSD-style license that can be | 3 # Use of this source code is governed by a BSD-style license that can be |
| 4 # found in the LICENSE file. | 4 # found in the LICENSE file. |
| 5 | 5 |
| 6 """ | 6 """ |
| 7 cr_cronet.py - cr - like helper tool for cronet developers | 7 cr_cronet.py - cr - like helper tool for cronet developers |
| 8 """ | 8 """ |
| 9 | 9 |
| 10 import argparse | 10 import argparse |
| (...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 88 out_dir_suffix = '-iphoneos' | 88 out_dir_suffix = '-iphoneos' |
| 89 else: | 89 else: |
| 90 gn_args += ' target_cpu="x64" ' | 90 gn_args += ' target_cpu="x64" ' |
| 91 out_dir_suffix = '-iphonesimulator' | 91 out_dir_suffix = '-iphonesimulator' |
| 92 if options.asan: | 92 if options.asan: |
| 93 gn_args += ' is_asan=true use_xcode_clang=true ' | 93 gn_args += ' is_asan=true use_xcode_clang=true ' |
| 94 out_dir_suffix += '-asan' | 94 out_dir_suffix += '-asan' |
| 95 else: | 95 else: |
| 96 target_os = 'android' | 96 target_os = 'android' |
| 97 test_target = 'cronet_test_instrumentation_apk' | 97 test_target = 'cronet_test_instrumentation_apk' |
| 98 gn_args = 'use_errorprone_java_compiler=true arm_use_neon=false ' | 98 gn_args = 'is_official_build=true use_errorprone_java_compiler=true arm_use_ neon=false ' |
|
mgersh
2017/05/16 21:22:55
Should this be only on release builds?
mef
2017/05/17 16:01:14
Done.
| |
| 99 gn_extra = '' | 99 gn_extra = '' |
| 100 out_dir_suffix = '' | 100 out_dir_suffix = '' |
| 101 | 101 |
| 102 gn_args += 'target_os="' + target_os + '" enable_websockets=false '+ \ | 102 gn_args += 'target_os="' + target_os + '" enable_websockets=false '+ \ |
| 103 'disable_file_support=true disable_ftp_support=true '+ \ | 103 'disable_file_support=true disable_ftp_support=true '+ \ |
| 104 'use_platform_icu_alternatives=true '+ \ | 104 'use_platform_icu_alternatives=true '+ \ |
| 105 'is_component_build=false ' + \ | 105 'is_component_build=false ' + \ |
| 106 'ignore_elf32_limitations=true use_partition_alloc=false' | 106 'ignore_elf32_limitations=true use_partition_alloc=false' |
| 107 | 107 |
| 108 extra_options = ' '.join(extra_options_list) | 108 extra_options = ' '.join(extra_options_list) |
| (...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 148 return test_ios(out_dir, extra_options) | 148 return test_ios(out_dir, extra_options) |
| 149 if (options.command=='build-test'): | 149 if (options.command=='build-test'): |
| 150 return build(out_dir, test_target) or test_ios(out_dir, extra_options) | 150 return build(out_dir, test_target) or test_ios(out_dir, extra_options) |
| 151 | 151 |
| 152 parser.print_help() | 152 parser.print_help() |
| 153 return 1 | 153 return 1 |
| 154 | 154 |
| 155 | 155 |
| 156 if __name__ == '__main__': | 156 if __name__ == '__main__': |
| 157 sys.exit(main()) | 157 sys.exit(main()) |
| OLD | NEW |
