Introduce EnabledUnselect for 'unselect' command

Introduce EnabledUnselect for 'unselect' command

Among user-triggered editing commands using EnabledVisibleSelection,
'unselect' is the only one that should be enabled when the selection doesn't
have focus. Hence, this patch adds EnabledUnselect as its enabled function,
so that a follow up patch can disable the remaining commands when the
selection doesn't have focus.

BUG=722925
TEST=n/a; no behavioral changes

Review-Url: https://codereview.chromium.org/2891493003
Cr-Commit-Position: refs/heads/master@{#472315}
Committed: https://chromium.googlesource.com/chromium/src/+/d93e3784b84a368cae59ba1b57dd4dfbe26ade24

[Xiaocheng, 2017-05-16 19:13:50]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-16 19:15:47]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 19:31:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 19:31:59]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Xiaocheng, 2017-05-16 19:44:09]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-16 19:45:14]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2017-05-16 21:01:34]

Description was changed from

==========
Introduce EnabledUnselect for 'unselect' command

BUG=722925
==========

to

==========
Introduce EnabledUnselect for 'unselect' command

Among user-triggered editing commands using EnabledVisibleSelection,
'unselect' is the only one that should be enabled when the selection doesn't
have focus. Hence, this patch adds EnabledUnselect as its enabled function,
so that a follow up patch can disable the remaining commands when the
selection doesn't have focus.

BUG=722925
TEST=n/a; no behavioral changes
==========

[Xiaocheng, 2017-05-16 21:01:45]

xiaochengh@chromium.org changed reviewers:
+ yosin@chromium.org

[Xiaocheng, 2017-05-16 21:01:45]

PTAL.

[commit-bot: I haz the power, 2017-05-16 21:20:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 21:20:00]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[yosin_UTC9, 2017-05-17 01:15:15]

The CQ bit was checked by yosin@chromium.org

[yosin_UTC9, 2017-05-17 01:15:15]

lgtm

[commit-bot: I haz the power, 2017-05-17 01:16:40]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 04:04:55]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494983715336390,
"parent_rev": "5f38c3cd32e96ccbf3f37653aeb30e8d268e9d36", "commit_rev":
"d93e3784b84a368cae59ba1b57dd4dfbe26ade24"}

[commit-bot: I haz the power, 2017-05-17 04:05:04]

Description was changed from

==========
Introduce EnabledUnselect for 'unselect' command

Among user-triggered editing commands using EnabledVisibleSelection,
'unselect' is the only one that should be enabled when the selection doesn't
have focus. Hence, this patch adds EnabledUnselect as its enabled function,
so that a follow up patch can disable the remaining commands when the
selection doesn't have focus.

BUG=722925
TEST=n/a; no behavioral changes
==========

to

==========
Introduce EnabledUnselect for 'unselect' command

Among user-triggered editing commands using EnabledVisibleSelection,
'unselect' is the only one that should be enabled when the selection doesn't
have focus. Hence, this patch adds EnabledUnselect as its enabled function,
so that a follow up patch can disable the remaining commands when the
selection doesn't have focus.

BUG=722925
TEST=n/a; no behavioral changes

Review-Url: https://codereview.chromium.org/2891493003
Cr-Commit-Position: refs/heads/master@{#472315}
Committed:
https://chromium.googlesource.com/chromium/src/+/d93e3784b84a368cae59ba1b57dd...
==========

[commit-bot: I haz the power, 2017-05-17 04:05:05]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d93e3784b84a368cae59ba1b57dd...