Make EnabledVisibleSelection return false for user-triggered command and unfocused selection

Make EnabledVisibleSelection return false for user-triggered command and unfocused selection

Certain editing commands shouldn't be enabled when they are user-triggered and
the selection doesn't have focus. This patch adds checking of
FrameSelection::SelectionHasFocus() in EnabledVisibleSelection() to fix
the behavior of these commands:

MoveBackwardAndModifySelection
MoveDownAndModifySelection
MoveForwardAndModifySelection
MoveLeftAndModifySelection
MovePageDownAndModifySelection
MovePageUpAndModifySelection
MoveParagraphBackwardAndModifySelection
MoveParagraphForwardAndModifySelection
MoveRightAndModifySelection
MoveToBeginningOfDocumentAndModifySelection
MoveToBeginningOfLineAndModifySelection
MoveToBeginningOfParagraphAndModifySelection
MoveToBeginningOfSentenceAndModifySelection
MoveToEndOfDocumentAndModifySelection
MoveToEndOfLineAndModifySelection
MoveToEndOfParagraphAndModifySelection
MoveToEndOfSentenceAndModifySelection
MoveUpAndModifySelection
MoveWordBackwardAndModifySelection
MoveWordForwardAndModifySelection
MoveWordLeftAndModifySelection
MoveWordRightAndModifySelection
SelectLine
SelectParagraph
SelectSentence
SelectWord
SetMark

BUG=722925
TEST=editing/selection/modify_extend/extend_with_unfocused_selection.html

Review-Url: https://codereview.chromium.org/2886983002
Cr-Commit-Position: refs/heads/master@{#472366}
Committed: https://chromium.googlesource.com/chromium/src/+/e9d6632785a0f1e94b4a15d3c2b3b54251162bc0

[Xiaocheng, 2017-05-16 21:32:05]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-16 21:35:55]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 23:14:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 23:14:37]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Xiaocheng, 2017-05-17 02:44:18]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[Xiaocheng, 2017-05-17 02:44:54]

Description was changed from

==========
Make EnabledVisibleSelection return false for user-triggered command and
unfocused selection

BUG=
==========

to

==========
Make EnabledVisibleSelection return false for user-triggered command and
unfocused selection

Certain editing commands shouldn't be enabled when they are user-triggered and
the selection doesn't have focus. This patch adds checking of
FrameSelection::SelectionHasFocus() in EnabledVisibleSelection() to fix
the behavior of these commands:

MoveBackwardAndModifySelection
MoveDownAndModifySelection
MoveForwardAndModifySelection
MoveLeftAndModifySelection
MovePageDownAndModifySelection
MovePageUpAndModifySelection
MoveParagraphBackwardAndModifySelection
MoveParagraphForwardAndModifySelection
MoveRightAndModifySelection
MoveToBeginningOfDocumentAndModifySelection
MoveToBeginningOfLineAndModifySelection
MoveToBeginningOfParagraphAndModifySelection
MoveToBeginningOfSentenceAndModifySelection
MoveToEndOfDocumentAndModifySelection
MoveToEndOfLineAndModifySelection
MoveToEndOfParagraphAndModifySelection
MoveToEndOfSentenceAndModifySelection
MoveUpAndModifySelection
MoveWordBackwardAndModifySelection
MoveWordForwardAndModifySelection
MoveWordLeftAndModifySelection
MoveWordRightAndModifySelection
SelectLine
SelectParagraph
SelectSentence
SelectWord
SetMark

BUG=
==========

[commit-bot: I haz the power, 2017-05-17 02:45:19]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2017-05-17 02:45:25]

Description was changed from

==========
Make EnabledVisibleSelection return false for user-triggered command and
unfocused selection

Certain editing commands shouldn't be enabled when they are user-triggered and
the selection doesn't have focus. This patch adds checking of
FrameSelection::SelectionHasFocus() in EnabledVisibleSelection() to fix
the behavior of these commands:

MoveBackwardAndModifySelection
MoveDownAndModifySelection
MoveForwardAndModifySelection
MoveLeftAndModifySelection
MovePageDownAndModifySelection
MovePageUpAndModifySelection
MoveParagraphBackwardAndModifySelection
MoveParagraphForwardAndModifySelection
MoveRightAndModifySelection
MoveToBeginningOfDocumentAndModifySelection
MoveToBeginningOfLineAndModifySelection
MoveToBeginningOfParagraphAndModifySelection
MoveToBeginningOfSentenceAndModifySelection
MoveToEndOfDocumentAndModifySelection
MoveToEndOfLineAndModifySelection
MoveToEndOfParagraphAndModifySelection
MoveToEndOfSentenceAndModifySelection
MoveUpAndModifySelection
MoveWordBackwardAndModifySelection
MoveWordForwardAndModifySelection
MoveWordLeftAndModifySelection
MoveWordRightAndModifySelection
SelectLine
SelectParagraph
SelectSentence
SelectWord
SetMark

BUG=
==========

to

==========
Make EnabledVisibleSelection return false for user-triggered command and
unfocused selection

Certain editing commands shouldn't be enabled when they are user-triggered and
the selection doesn't have focus. This patch adds checking of
FrameSelection::SelectionHasFocus() in EnabledVisibleSelection() to fix
the behavior of these commands:

MoveBackwardAndModifySelection
MoveDownAndModifySelection
MoveForwardAndModifySelection
MoveLeftAndModifySelection
MovePageDownAndModifySelection
MovePageUpAndModifySelection
MoveParagraphBackwardAndModifySelection
MoveParagraphForwardAndModifySelection
MoveRightAndModifySelection
MoveToBeginningOfDocumentAndModifySelection
MoveToBeginningOfLineAndModifySelection
MoveToBeginningOfParagraphAndModifySelection
MoveToBeginningOfSentenceAndModifySelection
MoveToEndOfDocumentAndModifySelection
MoveToEndOfLineAndModifySelection
MoveToEndOfParagraphAndModifySelection
MoveToEndOfSentenceAndModifySelection
MoveUpAndModifySelection
MoveWordBackwardAndModifySelection
MoveWordForwardAndModifySelection
MoveWordLeftAndModifySelection
MoveWordRightAndModifySelection
SelectLine
SelectParagraph
SelectSentence
SelectWord
SetMark

BUG=722925
TEST=editing/selection/modify_extend/extend_with_unfocused_selection.html
==========

[Xiaocheng, 2017-05-17 02:45:58]

xiaochengh@chromium.org changed reviewers:
+ yosin@chromium.org

[Xiaocheng, 2017-05-17 02:45:58]

PTAL.

[yosin_UTC9, 2017-05-17 03:26:26]

The CQ bit was unchecked by yosin@chromium.org

[yosin_UTC9, 2017-05-17 03:26:32]

The CQ bit was checked by yosin@chromium.org

[yosin_UTC9, 2017-05-17 03:26:33]

lgtm

[commit-bot: I haz the power, 2017-05-17 03:26:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 03:26:46]

This CL has an open dependency (Issue 2891493003 Patch 20001). Please resolve
the dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[xiaochengh, 2017-05-17 04:14:55]

The CQ bit was checked by xiaochengh@google.com

[commit-bot: I haz the power, 2017-05-17 04:15:40]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 05:37:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 05:37:56]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[xiaochengh, 2017-05-17 06:40:27]

The CQ bit was checked by xiaochengh@google.com

[commit-bot: I haz the power, 2017-05-17 06:41:06]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 07:20:35]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495003227201670,
"parent_rev": "b27dd8b56144f6373f05716a028b907a4fb21af2", "commit_rev":
"e9d6632785a0f1e94b4a15d3c2b3b54251162bc0"}

[commit-bot: I haz the power, 2017-05-17 07:20:49]

Description was changed from

==========
Make EnabledVisibleSelection return false for user-triggered command and
unfocused selection

Certain editing commands shouldn't be enabled when they are user-triggered and
the selection doesn't have focus. This patch adds checking of
FrameSelection::SelectionHasFocus() in EnabledVisibleSelection() to fix
the behavior of these commands:

MoveBackwardAndModifySelection
MoveDownAndModifySelection
MoveForwardAndModifySelection
MoveLeftAndModifySelection
MovePageDownAndModifySelection
MovePageUpAndModifySelection
MoveParagraphBackwardAndModifySelection
MoveParagraphForwardAndModifySelection
MoveRightAndModifySelection
MoveToBeginningOfDocumentAndModifySelection
MoveToBeginningOfLineAndModifySelection
MoveToBeginningOfParagraphAndModifySelection
MoveToBeginningOfSentenceAndModifySelection
MoveToEndOfDocumentAndModifySelection
MoveToEndOfLineAndModifySelection
MoveToEndOfParagraphAndModifySelection
MoveToEndOfSentenceAndModifySelection
MoveUpAndModifySelection
MoveWordBackwardAndModifySelection
MoveWordForwardAndModifySelection
MoveWordLeftAndModifySelection
MoveWordRightAndModifySelection
SelectLine
SelectParagraph
SelectSentence
SelectWord
SetMark

BUG=722925
TEST=editing/selection/modify_extend/extend_with_unfocused_selection.html
==========

to

==========
Make EnabledVisibleSelection return false for user-triggered command and
unfocused selection

Certain editing commands shouldn't be enabled when they are user-triggered and
the selection doesn't have focus. This patch adds checking of
FrameSelection::SelectionHasFocus() in EnabledVisibleSelection() to fix
the behavior of these commands:

MoveBackwardAndModifySelection
MoveDownAndModifySelection
MoveForwardAndModifySelection
MoveLeftAndModifySelection
MovePageDownAndModifySelection
MovePageUpAndModifySelection
MoveParagraphBackwardAndModifySelection
MoveParagraphForwardAndModifySelection
MoveRightAndModifySelection
MoveToBeginningOfDocumentAndModifySelection
MoveToBeginningOfLineAndModifySelection
MoveToBeginningOfParagraphAndModifySelection
MoveToBeginningOfSentenceAndModifySelection
MoveToEndOfDocumentAndModifySelection
MoveToEndOfLineAndModifySelection
MoveToEndOfParagraphAndModifySelection
MoveToEndOfSentenceAndModifySelection
MoveUpAndModifySelection
MoveWordBackwardAndModifySelection
MoveWordForwardAndModifySelection
MoveWordLeftAndModifySelection
MoveWordRightAndModifySelection
SelectLine
SelectParagraph
SelectSentence
SelectWord
SetMark

BUG=722925
TEST=editing/selection/modify_extend/extend_with_unfocused_selection.html

Review-Url: https://codereview.chromium.org/2886983002
Cr-Commit-Position: refs/heads/master@{#472366}
Committed:
https://chromium.googlesource.com/chromium/src/+/e9d6632785a0f1e94b4a15d3c2b3...
==========

[commit-bot: I haz the power, 2017-05-17 07:20:50]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/e9d6632785a0f1e94b4a15d3c2b3...