Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2891453005: Pipe the FirstPartyForCookies to WorkerFetchContext for off-main-thread-fetch (Closed)

Created:
3 years, 7 months ago by horo
Modified:
3 years, 7 months ago
Reviewers:
falken, kinuko
CC:
chromium-reviews, michaeln, mlamouri+watch-content_chromium.org, serviceworker-reviews, creis+watch_chromium.org, tzik, jsbell+serviceworker_chromium.org, nasko+codewatch_chromium.org, jam, kinuko+serviceworker, nhiroki, dglazkov+blink, darin-cc_chromium.org, blink-reviews, horo+watch_chromium.org, kinuko+watch, shimazu+serviceworker_chromium.org, blink-reviews-api_chromium.org, blink-worker-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Pipe the FirstPartyForCookies to WorkerFetchContext for off-main-thread-fetch BUG=443374 Review-Url: https://codereview.chromium.org/2891453005 Cr-Commit-Position: refs/heads/master@{#472721} Committed: https://chromium.googlesource.com/chromium/src/+/8d40bcabdcd220045cf57a0a2754298bbb818fc4

Patch Set 1 #

Total comments: 8

Patch Set 2 : incorporated falken's comment #

Patch Set 3 : fix WebWorkerFetchContext.h #

Patch Set 4 : rebase #

Patch Set 5 : SetRequestorOrigin #

Patch Set 6 : check the existing RequestorOrigin same as FrameFetchContext #

Patch Set 7 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -10 lines) Patch
M content/renderer/render_frame_impl.cc View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/service_worker/service_worker_context_client.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/service_worker/service_worker_fetch_context_impl.h View 3 chunks +4 lines, -0 lines 0 comments Download
M content/renderer/service_worker/service_worker_fetch_context_impl.cc View 2 chunks +11 lines, -1 line 0 comments Download
M content/renderer/service_worker/worker_fetch_context_impl.h View 1 2 3 3 chunks +6 lines, -1 line 0 comments Download
M content/renderer/service_worker/worker_fetch_context_impl.cc View 1 2 3 2 chunks +9 lines, -0 lines 0 comments Download
M content/renderer/shared_worker/embedded_shared_worker_stub.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/off-main-thread-fetch/http/tests/security/cookies/third-party-cookie-blocking-worker-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/loader/ThreadableLoadingContext.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/loader/WorkerFetchContext.h View 1 2 3 4 5 6 2 chunks +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/loader/WorkerFetchContext.cpp View 1 2 3 4 5 6 2 chunks +26 lines, -0 lines 0 comments Download
M third_party/WebKit/public/platform/WebWorkerFetchContext.h View 1 2 2 chunks +8 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 48 (32 generated)
horo
falken@ Could you please review this?
3 years, 7 months ago (2017-05-17 05:30:13 UTC) #4
falken
lgtm https://codereview.chromium.org/2891453005/diff/1/content/renderer/shared_worker/embedded_shared_worker_stub.cc File content/renderer/shared_worker/embedded_shared_worker_stub.cc (right): https://codereview.chromium.org/2891453005/diff/1/content/renderer/shared_worker/embedded_shared_worker_stub.cc#newcode277 content/renderer/shared_worker/embedded_shared_worker_stub.cc:277: // https://tools.ietf.org/html/draft-west-first-party-cookies-07#section-2.1.2 This sounds serious. Shall we open ...
3 years, 7 months ago (2017-05-17 08:55:31 UTC) #7
falken
https://codereview.chromium.org/2891453005/diff/1/third_party/WebKit/Source/core/loader/WorkerFetchContext.h File third_party/WebKit/Source/core/loader/WorkerFetchContext.h (right): https://codereview.chromium.org/2891453005/diff/1/third_party/WebKit/Source/core/loader/WorkerFetchContext.h#newcode72 third_party/WebKit/Source/core/loader/WorkerFetchContext.h:72: ResourceRequest&) override; On 2017/05/17 08:55:31, falken wrote: > I ...
3 years, 7 months ago (2017-05-17 09:00:05 UTC) #8
horo
https://codereview.chromium.org/2891453005/diff/1/content/renderer/shared_worker/embedded_shared_worker_stub.cc File content/renderer/shared_worker/embedded_shared_worker_stub.cc (right): https://codereview.chromium.org/2891453005/diff/1/content/renderer/shared_worker/embedded_shared_worker_stub.cc#newcode277 content/renderer/shared_worker/embedded_shared_worker_stub.cc:277: // https://tools.ietf.org/html/draft-west-first-party-cookies-07#section-2.1.2 On 2017/05/17 08:55:31, falken wrote: > This ...
3 years, 7 months ago (2017-05-17 09:44:04 UTC) #9
horo
kinuko@ Please review this.
3 years, 7 months ago (2017-05-17 09:46:43 UTC) #11
kinuko
lgtm
3 years, 7 months ago (2017-05-18 00:27:47 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2891453005/60001
3 years, 7 months ago (2017-05-18 00:29:50 UTC) #22
horo
On 2017/05/18 00:27:47, kinuko wrote: > lgtm I added SetRequestorOrigin() in SetFirstPartyCookieAndRequestorOrigin(). Initially I was ...
3 years, 7 months ago (2017-05-18 03:01:36 UTC) #26
kinuko
still lgtm
3 years, 7 months ago (2017-05-18 03:48:54 UTC) #31
horo
On 2017/05/18 03:48:54, kinuko wrote: > still lgtm Thank you!
3 years, 7 months ago (2017-05-18 03:56:33 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2891453005/100001
3 years, 7 months ago (2017-05-18 03:57:53 UTC) #36
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/440719)
3 years, 7 months ago (2017-05-18 04:12:26 UTC) #38
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2891453005/120001
3 years, 7 months ago (2017-05-18 04:27:00 UTC) #41
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/458563)
3 years, 7 months ago (2017-05-18 05:56:05 UTC) #43
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2891453005/120001
3 years, 7 months ago (2017-05-18 06:03:03 UTC) #45
commit-bot: I haz the power
3 years, 7 months ago (2017-05-18 07:34:04 UTC) #48
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/8d40bcabdcd220045cf57a0a2754...

Powered by Google App Engine
This is Rietveld 408576698