Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1207)

Issue 2890723002: Set the requester context info to the requests for off-main-thread-fetch. (Closed)

Created:
3 years, 7 months ago by horo
Modified:
3 years, 7 months ago
Reviewers:
falken, kinuko
CC:
chromium-reviews, michaeln, mlamouri+watch-content_chromium.org, serviceworker-reviews, creis+watch_chromium.org, tzik, jsbell+serviceworker_chromium.org, nasko+codewatch_chromium.org, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, blink-reviews, horo+watch_chromium.org, kinuko+watch, shimazu+serviceworker_chromium.org, blink-worker-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Set the requester context info to the requests for off-main-thread-fetch. This CL pipes the IsOriginSecure state to WorkerFetchContext and set it to the RequestExtraData at WorkerFetchContextImpl::WillSendRequest(). And WorkerFetchContext::PrepareRequest() sets the RequestorOrigin of requests. After this cl, foreign fetch tests will pass. BUG=443374 R=falken@chromium.org, kinuko@chromium.org Review-Url: https://codereview.chromium.org/2890723002 . Cr-Commit-Position: refs/heads/master@{#473086} Committed: https://chromium.googlesource.com/chromium/src/+/4c4e9325460f277a8db45b8b12d48efaddbdb841

Patch Set 1 #

Total comments: 8

Patch Set 2 : add comments #

Patch Set 3 : rebase #

Total comments: 8

Patch Set 4 : rebase and incorporated falken's comment #

Total comments: 2

Patch Set 5 : rebase and s/Set/Sets/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -10 lines) Patch
M content/renderer/render_frame_impl.cc View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/service_worker/worker_fetch_context_impl.h View 1 2 3 4 3 chunks +11 lines, -1 line 0 comments Download
M content/renderer/service_worker/worker_fetch_context_impl.cc View 1 2 3 2 chunks +5 lines, -0 lines 0 comments Download
M content/renderer/shared_worker/embedded_shared_worker_stub.cc View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/virtual/off-main-thread-fetch/external/wpt/service-workers/service-worker/foreign-fetch-workers.https-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 49 (32 generated)
horo
falken@ Please review this.
3 years, 7 months ago (2017-05-17 04:47:07 UTC) #4
falken
https://codereview.chromium.org/2890723002/diff/1/content/renderer/service_worker/worker_fetch_context_impl.h File content/renderer/service_worker/worker_fetch_context_impl.h (right): https://codereview.chromium.org/2890723002/diff/1/content/renderer/service_worker/worker_fetch_context_impl.h#newcode20 content/renderer/service_worker/worker_fetch_context_impl.h:20: just to be sure: this context is going to ...
3 years, 7 months ago (2017-05-17 08:40:26 UTC) #8
horo
https://codereview.chromium.org/2890723002/diff/1/content/renderer/service_worker/worker_fetch_context_impl.h File content/renderer/service_worker/worker_fetch_context_impl.h (right): https://codereview.chromium.org/2890723002/diff/1/content/renderer/service_worker/worker_fetch_context_impl.h#newcode20 content/renderer/service_worker/worker_fetch_context_impl.h:20: On 2017/05/17 08:40:26, falken wrote: > just to be ...
3 years, 7 months ago (2017-05-17 10:33:53 UTC) #9
falken
https://codereview.chromium.org/2890723002/diff/40001/content/renderer/service_worker/worker_fetch_context_impl.h File content/renderer/service_worker/worker_fetch_context_impl.h (right): https://codereview.chromium.org/2890723002/diff/40001/content/renderer/service_worker/worker_fetch_context_impl.h#newcode24 content/renderer/service_worker/worker_fetch_context_impl.h:24: // is created on the main thread and passed ...
3 years, 7 months ago (2017-05-18 02:14:14 UTC) #16
horo
https://codereview.chromium.org/2890723002/diff/40001/content/renderer/service_worker/worker_fetch_context_impl.h File content/renderer/service_worker/worker_fetch_context_impl.h (right): https://codereview.chromium.org/2890723002/diff/40001/content/renderer/service_worker/worker_fetch_context_impl.h#newcode24 content/renderer/service_worker/worker_fetch_context_impl.h:24: // is created on the main thread and passed ...
3 years, 7 months ago (2017-05-18 03:59:53 UTC) #19
falken
OK lgtm https://codereview.chromium.org/2890723002/diff/60001/content/renderer/service_worker/worker_fetch_context_impl.h File content/renderer/service_worker/worker_fetch_context_impl.h (right): https://codereview.chromium.org/2890723002/diff/60001/content/renderer/service_worker/worker_fetch_context_impl.h#newcode54 content/renderer/service_worker/worker_fetch_context_impl.h:54: // Set whether the worker context is ...
3 years, 7 months ago (2017-05-18 04:19:52 UTC) #24
horo
Thank you. https://codereview.chromium.org/2890723002/diff/60001/content/renderer/service_worker/worker_fetch_context_impl.h File content/renderer/service_worker/worker_fetch_context_impl.h (right): https://codereview.chromium.org/2890723002/diff/60001/content/renderer/service_worker/worker_fetch_context_impl.h#newcode54 content/renderer/service_worker/worker_fetch_context_impl.h:54: // Set whether the worker context is ...
3 years, 7 months ago (2017-05-18 04:24:08 UTC) #25
horo
kinuko@ Please review content/renderer/render_frame_impl.cc.
3 years, 7 months ago (2017-05-18 04:24:34 UTC) #27
kinuko
lgtm
3 years, 7 months ago (2017-05-18 05:04:25 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2890723002/80001
3 years, 7 months ago (2017-05-18 07:36:21 UTC) #35
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/448374)
3 years, 7 months ago (2017-05-18 12:45:06 UTC) #37
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2890723002/80001
3 years, 7 months ago (2017-05-18 12:46:14 UTC) #39
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/448478)
3 years, 7 months ago (2017-05-18 17:34:37 UTC) #41
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2890723002/80001
3 years, 7 months ago (2017-05-18 21:40:39 UTC) #43
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/449119)
3 years, 7 months ago (2017-05-19 04:06:10 UTC) #45
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2890723002/80001
3 years, 7 months ago (2017-05-19 04:09:45 UTC) #47
horo
3 years, 7 months ago (2017-05-19 04:31:46 UTC) #49
Message was sent while issue was closed.
Committed patchset #5 (id:80001) manually as
4c4e9325460f277a8db45b8b12d48efaddbdb841 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698