Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(903)

Issue 2891413002: [CUPS] Remove the left button in 'manufacturer-and-model' dialog. (Closed)

Created:
3 years, 7 months ago by xdai1
Modified:
3 years, 7 months ago
Reviewers:
michaelpg
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[CUPS] Remove the left button in 'manufacturer-and-model' dialog. BUG=721815 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2891413002 Cr-Commit-Position: refs/heads/master@{#474018} Committed: https://chromium.googlesource.com/chromium/src/+/f7e40af5029df0a20a92c5d0c71b26d8247e370b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -51 lines) Patch
M chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html View 3 chunks +12 lines, -26 lines 0 comments Download
M chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.js View 7 chunks +12 lines, -25 lines 0 comments Download

Messages

Total messages: 15 (11 generated)
xdai1
michaelpg@, could you help review this CL please? Thanks!
3 years, 7 months ago (2017-05-22 16:54:33 UTC) #5
michaelpg
lgtm
3 years, 7 months ago (2017-05-23 17:07:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2891413002/1
3 years, 7 months ago (2017-05-23 17:58:30 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-23 20:08:45 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f7e40af5029df0a20a92c5d0c71b...

Powered by Google App Engine
This is Rietveld 408576698