Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4323)

Unified Diff: chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.js

Issue 2891413002: [CUPS] Remove the left button in 'manufacturer-and-model' dialog. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.js
diff --git a/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.js b/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.js
index 7249ba113ac06ce3e31bb1aa2b1ecc94350e50e5..8e1d7de443205c16582434c5e374fa71b1a13b89 100644
--- a/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.js
+++ b/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.js
@@ -214,9 +214,6 @@ Polymer({
type: Array,
},
- /** @type {string} */
- previousDialog: String,
-
setupFailed: {
type: Boolean,
value: false,
@@ -283,16 +280,6 @@ Polymer({
},
/** @private */
- switchToPreviousDialog_: function() {
- this.$$('add-printer-dialog').close();
- if (this.previousDialog == AddPrinterDialogs.DISCOVERY) {
- this.fire('open-discovery-printers-dialog');
- } else if (this.previousDialog == AddPrinterDialogs.MANUALLY) {
- this.fire('open-manually-add-printer-dialog');
- }
- },
-
- /** @private */
onCancelTap_: function() {
this.$$('add-printer-dialog').close();
},
@@ -368,8 +355,8 @@ Polymer({
configuringDialogTitle: String,
- /** @type {string} */
- previousDialog: String,
+ /** @private {string} */
+ previousDialog_: String,
/** @private {string} */
currentDialog_: String,
@@ -433,12 +420,12 @@ Polymer({
this.switchDialog_(
this.currentDialog_, AddPrinterDialogs.CONFIGURING,
'showConfiguringDialog_');
- if (this.previousDialog == AddPrinterDialogs.DISCOVERY) {
+ if (this.previousDialog_ == AddPrinterDialogs.DISCOVERY) {
this.configuringDialogTitle =
loadTimeData.getString('addPrintersNearbyTitle');
settings.CupsPrintersBrowserProxyImpl.getInstance().addCupsPrinter(
this.newPrinter);
- } else if (this.previousDialog == AddPrinterDialogs.MANUFACTURER) {
+ } else if (this.previousDialog_ == AddPrinterDialogs.MANUFACTURER) {
this.configuringDialogTitle =
loadTimeData.getString('addPrintersManuallyTitle');
settings.CupsPrintersBrowserProxyImpl.getInstance().addCupsPrinter(
@@ -460,15 +447,15 @@ Polymer({
// clean up the way we switch dialogs so we don't have to supply
// redundant information and can just return to the previous
// dialog.
- if (this.previousDialog == AddPrinterDialogs.DISCOVERY) {
+ if (this.previousDialog_ == AddPrinterDialogs.DISCOVERY) {
this.switchDialog_(
- this.currentDialog_, this.previousDialog, 'showDiscoveryDialog_');
- } else if (this.previousDialog == AddPrinterDialogs.MANUALLY) {
+ this.currentDialog_, this.previousDialog_, 'showDiscoveryDialog_');
+ } else if (this.previousDialog_ == AddPrinterDialogs.MANUALLY) {
this.switchDialog_(
- this.currentDialog_, this.previousDialog, 'showManuallyAddDialog_');
- } else if (this.previousDialog == AddPrinterDialogs.MANUFACTURER) {
+ this.currentDialog_, this.previousDialog_, 'showManuallyAddDialog_');
+ } else if (this.previousDialog_ == AddPrinterDialogs.MANUFACTURER) {
this.switchDialog_(
- this.currentDialog_, this.previousDialog, 'showManufacturerDialog_');
+ this.currentDialog_, this.previousDialog_, 'showManufacturerDialog_');
}
},
@@ -481,7 +468,7 @@ Polymer({
* @private
*/
switchDialog_: function(fromDialog, toDialog, domIfBooleanName) {
- this.previousDialog = fromDialog;
+ this.previousDialog_ = fromDialog;
this.currentDialog_ = toDialog;
this.set(domIfBooleanName, true);
@@ -503,7 +490,7 @@ Polymer({
if (success)
return;
- if (this.previousDialog == AddPrinterDialogs.MANUFACTURER) {
+ if (this.previousDialog_ == AddPrinterDialogs.MANUFACTURER) {
this.setupFailed = true;
}
},
« no previous file with comments | « chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698