Add long press actions for Most Visited tiles

Add long press actions for Most Visited tiles

Add the long press actions for the Most Visited tiles:
- Open in New Tab
- Open in New Incognito Tab
- Delete

BUG=724427
Review-Url: https://codereview.chromium.org/2891363002
Cr-Commit-Position: refs/heads/master@{#477270}
Committed: https://chromium.googlesource.com/chromium/src/+/e810041bc721983ffc3331c1a4ec69726fbfc0d0

[gambard, 2017-05-19 14:48:01]

gambard@chromium.org changed reviewers:
+ lpromero@chromium.org

[gambard, 2017-05-19 14:48:01]

PTAL.

[lpromero, 2017-05-22 13:19:06]

lgtm with comments.

https://codereview.chromium.org/2891363002/diff/20001/ios/chrome/browser/cont...
File ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm
(right):

https://codereview.chromium.org/2891363002/diff/20001/ios/chrome/browser/cont...
ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm:231:
style:UIAlertActionStyleDefault];
Should this be UIAlertActionStyleDestructive?

https://codereview.chromium.org/2891363002/diff/20001/ios/chrome/browser/cont...
ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm:256:
GURL URL = mostVisitedItem.URL;
Seems unused below.

https://codereview.chromium.org/2891363002/diff/20001/ios/chrome/browser/cont...
ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm:303:
style:UIAlertActionStyleDefault];
Should this be UIAlertActionStyleDestructive?

https://codereview.chromium.org/2891363002/diff/20001/ios/chrome/browser/cont...
File ios/chrome/browser/content_suggestions/content_suggestions_mediator.h
(right):

https://codereview.chromium.org/2891363002/diff/20001/ios/chrome/browser/cont...
ios/chrome/browser/content_suggestions/content_suggestions_mediator.h:56: //
Blacklist the URL from the Most Visited sites.
s/Blacklist/Blacklists

https://codereview.chromium.org/2891363002/diff/20001/ios/chrome/browser/cont...
ios/chrome/browser/content_suggestions/content_suggestions_mediator.h:59: //
Whitelist the URL from the Most Visited sites.
s/Whitelist/Whitelists

[gambard, 2017-06-02 14:57:11]

Thanks!

https://codereview.chromium.org/2891363002/diff/20001/ios/chrome/browser/cont...
File ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm
(right):

https://codereview.chromium.org/2891363002/diff/20001/ios/chrome/browser/cont...
ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm:231:
style:UIAlertActionStyleDefault];
On 2017/05/22 13:19:06, lpromero wrote:
> Should this be UIAlertActionStyleDestructive?

It is not in the current UI/mocks. But there is a bug to know if it should be
changed.

https://codereview.chromium.org/2891363002/diff/20001/ios/chrome/browser/cont...
ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm:256:
GURL URL = mostVisitedItem.URL;
On 2017/05/22 13:19:06, lpromero wrote:
> Seems unused below.

Done.

https://codereview.chromium.org/2891363002/diff/20001/ios/chrome/browser/cont...
ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm:303:
style:UIAlertActionStyleDefault];
On 2017/05/22 13:19:06, lpromero wrote:
> Should this be UIAlertActionStyleDestructive?

Same answer

https://codereview.chromium.org/2891363002/diff/20001/ios/chrome/browser/cont...
File ios/chrome/browser/content_suggestions/content_suggestions_mediator.h
(right):

https://codereview.chromium.org/2891363002/diff/20001/ios/chrome/browser/cont...
ios/chrome/browser/content_suggestions/content_suggestions_mediator.h:56: //
Blacklist the URL from the Most Visited sites.
On 2017/05/22 13:19:06, lpromero wrote:
> s/Blacklist/Blacklists

Done.

https://codereview.chromium.org/2891363002/diff/20001/ios/chrome/browser/cont...
ios/chrome/browser/content_suggestions/content_suggestions_mediator.h:59: //
Whitelist the URL from the Most Visited sites.
On 2017/05/22 13:19:06, lpromero wrote:
> s/Whitelist/Whitelists

Done.

[gambard, 2017-06-06 12:13:05]

The CQ bit was checked by gambard@chromium.org

[gambard, 2017-06-06 12:13:05]

The patchset sent to the CQ was uploaded after l-g-t-m from
lpromero@chromium.org
Link to the patchset: https://codereview.chromium.org/2891363002/#ps40001
(title: "Address comments")

[commit-bot: I haz the power, 2017-06-06 12:13:07]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-06 13:20:18]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1496751185136240,
"parent_rev": "ebffb3817ff49461fbf067d87c1de24a99cdf992", "commit_rev":
"e810041bc721983ffc3331c1a4ec69726fbfc0d0"}

[commit-bot: I haz the power, 2017-06-06 13:20:29]

Description was changed from

==========
Add long press actions for Most Visited tiles

Add the long press actions for the Most Visited tiles:
- Open in New Tab
- Open in New Incognito Tab
- Delete

BUG=724427
==========

to

==========
Add long press actions for Most Visited tiles

Add the long press actions for the Most Visited tiles:
- Open in New Tab
- Open in New Incognito Tab
- Delete

BUG=724427

Review-Url: https://codereview.chromium.org/2891363002
Cr-Commit-Position: refs/heads/master@{#477270}
Committed:
https://chromium.googlesource.com/chromium/src/+/e810041bc721983ffc3331c1a4ec...
==========

[commit-bot: I haz the power, 2017-06-06 13:20:30]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/e810041bc721983ffc3331c1a4ec...