Open Most Visited items

Open Most Visited items

Open the Most Visited items when tapped and log the action.

BUG=724427
Review-Url: https://codereview.chromium.org/2890193003
Cr-Commit-Position: refs/heads/master@{#477262}
Committed: https://chromium.googlesource.com/chromium/src/+/d9ba02556dbc40c2059778aaab0f3e1dabc1acd0

[gambard, 2017-05-19 11:51:12]

gambard@chromium.org changed reviewers:
+ marq@chromium.org

[gambard, 2017-05-19 11:51:12]

PTAL.

[marq (ping after 24h), 2017-06-02 08:25:47]

LGTM with one very optional nit. Nice work.

https://codereview.chromium.org/2890193003/diff/20001/ios/chrome/browser/ui/c...
File
ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm
(right):

https://codereview.chromium.org/2890193003/diff/20001/ios/chrome/browser/ui/c...
ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm:278:
- (void)blurOmnibox {
Minor naming nit: when 'focus' is used to mean 'make the active UI element', I
don't think of 'blur' being the inverse operation; my expectation was that
'blurOmnibox' would apply a blur effect. 'defocusOmibox' would make more sense
to me. It's possible this is just me, though.

[gambard, 2017-06-02 13:26:59]

https://codereview.chromium.org/2890193003/diff/20001/ios/chrome/browser/ui/c...
File
ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm
(right):

https://codereview.chromium.org/2890193003/diff/20001/ios/chrome/browser/ui/c...
ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm:278:
- (void)blurOmnibox {
On 2017/06/02 08:25:47, marq (ping after 24h) wrote:
> Minor naming nit: when 'focus' is used to mean 'make the active UI element', I
> don't think of 'blur' being the inverse operation; my expectation was that
> 'blurOmnibox' would apply a blur effect. 'defocusOmibox' would make more sense
> to me. It's possible this is just me, though.

I had the same reaction as you :)
But as defocus was not in my dictionary I stuck with the method name currently
used in Google Landing Controller.
If you think "defocus" makes sense in english I would be glad to use it. I also
thought of "unfocus".
Do you have any preference?

[gambard, 2017-06-06 09:42:30]

The CQ bit was checked by gambard@chromium.org

[gambard, 2017-06-06 09:42:30]

The patchset sent to the CQ was uploaded after l-g-t-m from marq@chromium.org
Link to the patchset: https://codereview.chromium.org/2890193003/#ps60001
(title: "Change function name")

[commit-bot: I haz the power, 2017-06-06 09:42:47]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gambard, 2017-06-06 09:50:42]

The CQ bit was unchecked by gambard@chromium.org

[gambard, 2017-06-06 09:52:29]

The CQ bit was checked by gambard@chromium.org

[gambard, 2017-06-06 09:52:30]

The patchset sent to the CQ was uploaded after l-g-t-m from marq@chromium.org
Link to the patchset: https://codereview.chromium.org/2890193003/#ps80001
(title: "Change function name again")

[commit-bot: I haz the power, 2017-06-06 09:52:46]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-06 10:01:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-06 10:01:59]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[gambard, 2017-06-06 10:05:30]

The CQ bit was checked by gambard@chromium.org

[gambard, 2017-06-06 10:05:31]

The patchset sent to the CQ was uploaded after l-g-t-m from marq@chromium.org
Link to the patchset: https://codereview.chromium.org/2890193003/#ps100001
(title: "Fix showcase")

[commit-bot: I haz the power, 2017-06-06 10:05:48]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-06 12:01:40]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1496743530699370,
"parent_rev": "97d2eb259484cb04b331ac05367ff2bb1c31ed5a", "commit_rev":
"d9ba02556dbc40c2059778aaab0f3e1dabc1acd0"}

[commit-bot: I haz the power, 2017-06-06 12:01:50]

Description was changed from

==========
Open Most Visited items

Open the Most Visited items when tapped and log the action.

BUG=724427
==========

to

==========
Open Most Visited items

Open the Most Visited items when tapped and log the action.

BUG=724427

Review-Url: https://codereview.chromium.org/2890193003
Cr-Commit-Position: refs/heads/master@{#477262}
Committed:
https://chromium.googlesource.com/chromium/src/+/d9ba02556dbc40c2059778aaab0f...
==========

[commit-bot: I haz the power, 2017-06-06 12:01:51]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/d9ba02556dbc40c2059778aaab0f...