[ignition] Use an intrinsic for GeneratorClose.

[ignition] Use an intrinsic for GeneratorClose.

GeneratorClose is pretty simple, we can handle it in the interpreter.

BUG=v8:6351
Review-Url: https://codereview.chromium.org/2891353002
Cr-Commit-Position: refs/heads/master@{#45434}
Committed: https://chromium.googlesource.com/v8/v8/+/c476e8afc1dfe9245c85d3ee150d206ff86fee3b

[mvstanton, 2017-05-19 13:18:40]

The CQ bit was checked by mvstanton@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-19 13:18:46]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mvstanton, 2017-05-19 13:19:45]

mvstanton@chromium.org changed reviewers:
+ rmcilroy@chromium.org

[mvstanton, 2017-05-19 13:19:46]

Hi Ross,
One more, I just forgot this one in the previous batch of intrinsics.
Thanks!
--Michael

[commit-bot: I haz the power, 2017-05-19 14:04:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 14:05:00]

Dry run: This issue passed the CQ dry run.

[rmcilroy, 2017-05-19 15:38:05]

Add a bug= label? 

Otherwise, LGTM, thanks!

[mvstanton, 2017-05-19 17:33:57]

Description was changed from

==========
[ignition] Use an intrinsic for GeneratorClose.

GeneratorClose is pretty simple, we can handle it in the interpreter.

BUG=
==========

to

==========
[ignition] Use an intrinsic for GeneratorClose.

GeneratorClose is pretty simple, we can handle it in the interpreter.

BUG=v8:6351
==========

[mvstanton, 2017-05-19 17:34:16]

Done, enjoy the weekend :)

[mvstanton, 2017-05-19 17:34:23]

The CQ bit was checked by mvstanton@chromium.org

[commit-bot: I haz the power, 2017-05-19 17:34:30]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 17:36:09]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1495215263054120, "parent_rev":
"930e31e6e62dc67a97d7e745a878968b8f72e237", "commit_rev":
"c476e8afc1dfe9245c85d3ee150d206ff86fee3b"}

[commit-bot: I haz the power, 2017-05-19 17:36:16]

Description was changed from

==========
[ignition] Use an intrinsic for GeneratorClose.

GeneratorClose is pretty simple, we can handle it in the interpreter.

BUG=v8:6351
==========

to

==========
[ignition] Use an intrinsic for GeneratorClose.

GeneratorClose is pretty simple, we can handle it in the interpreter.

BUG=v8:6351

Review-Url: https://codereview.chromium.org/2891353002
Cr-Commit-Position: refs/heads/master@{#45434}
Committed:
https://chromium.googlesource.com/v8/v8/+/c476e8afc1dfe9245c85d3ee150d206ff86...
==========

[commit-bot: I haz the power, 2017-05-19 17:36:17]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/c476e8afc1dfe9245c85d3ee150d206ff86...

[neis1, 2017-05-19 17:58:11]

neis@google.com changed reviewers:
+ neis@google.com

[neis1, 2017-05-19 17:58:12]

https://codereview.chromium.org/2891353002/diff/1/src/interpreter/interpreter...
File src/interpreter/interpreter-intrinsics-generator.cc (right):

https://codereview.chromium.org/2891353002/diff/1/src/interpreter/interpreter...
src/interpreter/interpreter-intrinsics-generator.cc:448: 
I don't think we need to read and return the mode of the last resumption here.
Is that a copy-paste leftover?

[mvstanton, 2017-05-19 19:11:38]

https://codereview.chromium.org/2891353002/diff/1/src/interpreter/interpreter...
File src/interpreter/interpreter-intrinsics-generator.cc (right):

https://codereview.chromium.org/2891353002/diff/1/src/interpreter/interpreter...
src/interpreter/interpreter-intrinsics-generator.cc:448: 
On 2017/05/19 17:58:12, neis1 wrote:
> I don't think we need to read and return the mode of the last resumption here.
> Is that a copy-paste leftover?

Good catch! Yes, the runtime function just returns undefined -- I'll craft a fix
asap...