[ignition] Use an intrinsic for GeneratorClose.

src/interpreter/interpreter-intrinsics-generator.cc

 // Copyright 2017 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/interpreter/interpreter-intrinsics-generator.h"
 
 #include "src/allocation.h"
 #include "src/builtins/builtins.h"
 #include "src/code-factory.h"
 #include "src/frames.h"
@@ skipping 416 matching lines @@
 Node* IntrinsicsGenerator::GeneratorGetResumeMode(Node* args_reg,
                                                   Node* arg_count,
                                                   Node* context) {
   Node* generator = __ LoadRegister(args_reg);
   Node* const value =
       __ LoadObjectField(generator, JSGeneratorObject::kResumeModeOffset);
 
   return value;
 }
 
+Node* IntrinsicsGenerator::GeneratorClose(Node* args_reg, Node* arg_count,
+                                          Node* context) {
+  Node* generator = __ LoadRegister(args_reg);
+  Node* const value =
+      __ LoadObjectField(generator, JSGeneratorObject::kResumeModeOffset);
+  __ StoreObjectFieldNoWriteBarrier(
+      generator, JSGeneratorObject::kContinuationOffset,
+      __ SmiConstant(JSGeneratorObject::kGeneratorClosed));
+
+  return value;
+}
+

[neis1, 2017/05/19 17:58:12]

I don't think we need to read and return the mode of the last resumption here.
Is that a copy-paste leftover?

[mvstanton, 2017/05/19 19:11:37]

Good catch! Yes, the runtime function just returns undefined -- I'll craft a fix
asap...

 Node* IntrinsicsGenerator::AsyncGeneratorReject(Node* input, Node* arg_count,
                                                 Node* context) {
   return IntrinsicAsBuiltinCall(input, context,
                                 Builtins::kAsyncGeneratorReject);
 }
 
 Node* IntrinsicsGenerator::AsyncGeneratorResolve(Node* input, Node* arg_count,
                                                  Node* context) {
   return IntrinsicAsBuiltinCall(input, context,
                                 Builtins::kAsyncGeneratorResolve);
 }
 
 void IntrinsicsGenerator::AbortIfArgCountMismatch(int expected, Node* actual) {
   InterpreterAssembler::Label match(assembler_);
   Node* comparison = __ Word32Equal(actual, __ Int32Constant(expected));
   __ GotoIf(comparison, &match);
   __ Abort(kWrongArgumentCountForInvokeIntrinsic);
   __ Goto(&match);
   __ Bind(&match);
 }
 
 }  // namespace interpreter
 }  // namespace internal
 }  // namespace v8