Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 2891323002: Revert of Add DEPS.chromium for recursive DEPS tracking. (Closed)

Created:
3 years, 7 months ago by martyn.capewell
Modified:
3 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Add DEPS.chromium for recursive DEPS tracking. (patchset #1 id:1 of https://codereview.chromium.org/2880293002/ ) Reason for revert: Going a different way with this, as Chromium don't want the additional files. Original issue's description: > Add DEPS.chromium for recursive DEPS tracking. > > DEPS.chromium allows the Chromium build system's DEPS to recurse into V8's own > dependencies. Initially, this is populated with some tests files for the ARM64 > simulator. > > BUG=chromium:718439 > > Review-Url: https://codereview.chromium.org/2880293002 > Cr-Commit-Position: refs/heads/master@{#45310} > Committed: https://chromium.googlesource.com/v8/v8/+/f8a6c6c48e79ef4267d03c80aa768e8362341e4a TBR=machenbach@chromium.org,bmeurer@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:718439 Review-Url: https://codereview.chromium.org/2891323002 Cr-Commit-Position: refs/heads/master@{#45420} Committed: https://chromium.googlesource.com/v8/v8/+/822442f0f64f4f5caf7936fd401f8f7fa8f2e771

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -14 lines) Patch
D DEPS.chromium View 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
martyn.capewell
Created Revert of Add DEPS.chromium for recursive DEPS tracking.
3 years, 7 months ago (2017-05-19 10:11:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2891323002/1
3 years, 7 months ago (2017-05-19 10:11:30 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-19 10:39:48 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/822442f0f64f4f5caf7936fd401f8f7fa8f...

Powered by Google App Engine
This is Rietveld 408576698