Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2880293002: Add DEPS.chromium for recursive DEPS tracking. (Closed)

Created:
3 years, 7 months ago by martyn.capewell
Modified:
3 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Add DEPS.chromium for recursive DEPS tracking. DEPS.chromium allows the Chromium build system's DEPS to recurse into V8's own dependencies. Initially, this is populated with some tests files for the ARM64 simulator. BUG=chromium:718439 Review-Url: https://codereview.chromium.org/2880293002 Cr-Commit-Position: refs/heads/master@{#45310} Committed: https://chromium.googlesource.com/v8/v8/+/f8a6c6c48e79ef4267d03c80aa768e8362341e4a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
A DEPS.chromium View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
martyn.capewell
3 years, 7 months ago (2017-05-15 14:20:23 UTC) #3
Michael Achenbach
lgtm
3 years, 7 months ago (2017-05-15 14:28:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2880293002/1
3 years, 7 months ago (2017-05-15 14:29:21 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/f8a6c6c48e79ef4267d03c80aa768e8362341e4a
3 years, 7 months ago (2017-05-15 15:23:56 UTC) #9
martyn.capewell
3 years, 7 months ago (2017-05-19 10:11:21 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2891323002/ by martyn.capewell@arm.com.

The reason for reverting is: Going a different way with this, as Chromium don't
want the additional files..

Powered by Google App Engine
This is Rietveld 408576698