Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1058)

Issue 2891273003: Make VisibleUnits::ComputeTextRect() return unified IntRect (Closed)

Created:
1 year, 1 month ago by yoichio
Modified:
1 year, 1 month ago
Reviewers:
tkent, yosin_UTC9
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make VisibleUnits::ComputeTextRect() return unified IntRect Only Range uses Vector<IntRect> but it unifies and return a IntRect. Just unify in VisibleUnits::ComputeTextRect() directly. TEST=No change in behavior BUG=712986 Review-Url: https://codereview.chromium.org/2891273003 Cr-Commit-Position: refs/heads/master@{#473185} Committed: https://chromium.googlesource.com/chromium/src/+/d77cd716740a94334fc7c98749876f4a013b8322

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M third_party/WebKit/Source/core/dom/Range.cpp View 1 chunk +1 line, -5 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleUnits.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleUnits.cpp View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
yoichio
1 year, 1 month ago (2017-05-19 08:18:56 UTC) #4
yoichio
1 year, 1 month ago (2017-05-19 08:18:56 UTC) #5
yoichio
1 year, 1 month ago (2017-05-19 08:19:22 UTC) #7
yosin_UTC9
lgtm +tkent@
1 year, 1 month ago (2017-05-19 08:42:30 UTC) #9
tkent
lgtm
1 year, 1 month ago (2017-05-19 08:48:49 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2891273003/1
1 year, 1 month ago (2017-05-19 10:23:57 UTC) #14
commit-bot: I haz the power
1 year, 1 month ago (2017-05-19 14:44:34 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d77cd716740a94334fc7c9874987...

Powered by Google App Engine
This is Rietveld 408576698