Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Unified Diff: third_party/WebKit/Source/core/dom/Range.cpp

Issue 2891273003: Make VisibleUnits::ComputeTextRect() return unified IntRect (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/VisibleUnits.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/dom/Range.cpp
diff --git a/third_party/WebKit/Source/core/dom/Range.cpp b/third_party/WebKit/Source/core/dom/Range.cpp
index de056bbffe1d70c4388b1d4ddd094fde4bebe475..51d913490bc7aeacaa3e4bead7ed7c6ef647ddcd 100644
--- a/third_party/WebKit/Source/core/dom/Range.cpp
+++ b/third_party/WebKit/Source/core/dom/Range.cpp
@@ -1441,11 +1441,7 @@ Node* Range::PastLastNode() const {
}
IntRect Range::BoundingBox() const {
- IntRect result;
- const Vector<IntRect>& rects = ComputeTextRects(EphemeralRange(this));
- for (const IntRect& rect : rects)
- result.Unite(rect);
- return result;
+ return ComputeTextRect(EphemeralRange(this));
}
// TODO(tanvir.rizvi): We will replace Range::TextQuads with
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/VisibleUnits.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698