Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2891173002: [DMC #9] Rename DocumentMarkerController::InvalidateRects*() methods (Closed)

Created:
3 years, 7 months ago by rlanday
Modified:
3 years, 7 months ago
Reviewers:
tkent, yosin_UTC9, Xiaocheng
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename DocumentMarkerController::InvalidateRects*() methods Renaming InvalidateRectsForAllMarkers() to InvalidateRectsForTextMatchMarkers() and InvalidateRectsForMarkersInNode() to InvalidateRectsForTextMatchMarkersInNode() to reflect that we're only creating RenderedDocumentMarkers (which hold the rects) for TextMatch markers after https://codereview.chromium.org/2886893008. BUG=707867 Review-Url: https://codereview.chromium.org/2891173002 Cr-Commit-Position: refs/heads/master@{#473483} Committed: https://chromium.googlesource.com/chromium/src/+/a55089594a4bb75655e016b48c15dc368e159fda

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M third_party/WebKit/Source/core/dom/Document.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp View 3 chunks +4 lines, -4 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 19 (11 generated)
rlanday
3 years, 7 months ago (2017-05-18 21:15:47 UTC) #3
yosin_UTC9
lgtm +tkent@ for core/dom/Document.cpp Note: I filed a bug[1] about invalidating text markers in Document::LayoutUpdated() ...
3 years, 7 months ago (2017-05-19 06:30:53 UTC) #8
tkent
lgtm
3 years, 7 months ago (2017-05-19 06:32:37 UTC) #9
Xiaocheng
lgtm
3 years, 7 months ago (2017-05-19 18:17:38 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2891173002/1
3 years, 7 months ago (2017-05-21 19:25:32 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/432748)
3 years, 7 months ago (2017-05-21 20:45:53 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2891173002/1
3 years, 7 months ago (2017-05-21 20:49:53 UTC) #16
commit-bot: I haz the power
3 years, 7 months ago (2017-05-21 21:24:46 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a55089594a4bb75655e016b48c15...

Powered by Google App Engine
This is Rietveld 408576698