Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 2891043002: Revert of Remove WINDOW_TYPE_V1_PANEL AppWindow type (Closed)

Created:
3 years, 7 months ago by Marc Treib
Modified:
3 years, 7 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, tfarina, sadrul, kalyank, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove WINDOW_TYPE_V1_PANEL AppWindow type (patchset #2 id:20001 of https://codereview.chromium.org/2886293002/ ) Reason for revert: Breaks compile on ChromiumOS x86-generic due to unused-but-set variable saw_focus_key Original issue's description: > Remove WINDOW_TYPE_V1_PANEL AppWindow type > > Changes: > Currently, panel window is only used as Chrome OS's audio player, which is WINDOW_TYPE_PANEL. WINDOW_TYPE_V1_PANEL is not a AppWindow type in use any more. Remove it in code base. > > BUG=691099 > TEST=covered by tests > > Review-Url: https://codereview.chromium.org/2886293002 > Cr-Commit-Position: refs/heads/master@{#472661} > Committed: https://chromium.googlesource.com/chromium/src/+/0775f98187d5d895b15b46212f55d30956aa946e TBR=benwells@chromium.org,oshima@chromium.org,warx@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=691099 Review-Url: https://codereview.chromium.org/2891043002 Cr-Commit-Position: refs/heads/master@{#472740} Committed: https://chromium.googlesource.com/chromium/src/+/3cb8f0afe629acb8806b0d20ec00d539f7114406

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -4 lines) Patch
M chrome/browser/extensions/api/tabs/tabs_api.cc View 4 chunks +43 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/ui/views/apps/chrome_native_app_window_views.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/browser/app_window/app_window.h View 2 chunks +4 lines, -1 line 0 comments Download
M extensions/components/native_app_window/native_app_window_views.h View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/components/native_app_window/native_app_window_views.cc View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
Marc Treib
Created Revert of Remove WINDOW_TYPE_V1_PANEL AppWindow type
3 years, 7 months ago (2017-05-18 08:27:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2891043002/1
3 years, 7 months ago (2017-05-18 08:27:44 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-18 08:28:33 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3cb8f0afe629acb8806b0d20ec00...

Powered by Google App Engine
This is Rietveld 408576698