DescriptionRevert of Remove WINDOW_TYPE_V1_PANEL AppWindow type (patchset #2 id:20001 of https://codereview.chromium.org/2886293002/ )
Reason for revert:
Breaks compile on ChromiumOS x86-generic due to unused-but-set variable saw_focus_key
Original issue's description:
> Remove WINDOW_TYPE_V1_PANEL AppWindow type
>
> Changes:
> Currently, panel window is only used as Chrome OS's audio player, which is WINDOW_TYPE_PANEL. WINDOW_TYPE_V1_PANEL is not a AppWindow type in use any more. Remove it in code base.
>
> BUG=691099
> TEST=covered by tests
>
> Review-Url: https://codereview.chromium.org/2886293002
> Cr-Commit-Position: refs/heads/master@{#472661}
> Committed: https://chromium.googlesource.com/chromium/src/+/0775f98187d5d895b15b46212f55d30956aa946e
TBR=benwells@chromium.org,oshima@chromium.org,warx@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=691099
Review-Url: https://codereview.chromium.org/2891043002
Cr-Commit-Position: refs/heads/master@{#472740}
Committed: https://chromium.googlesource.com/chromium/src/+/3cb8f0afe629acb8806b0d20ec00d539f7114406
Patch Set 1 #
Messages
Total messages: 6 (3 generated)
|