Remove WINDOW_TYPE_V1_PANEL AppWindow type

Remove WINDOW_TYPE_V1_PANEL AppWindow type

Changes:
Currently, panel window is only used as Chrome OS's audio player, which is WINDOW_TYPE_PANEL. WINDOW_TYPE_V1_PANEL is not a AppWindow type in use any more. Remove it in code base.

BUG=691099
TEST=covered by tests

Review-Url: https://codereview.chromium.org/2886293002
Cr-Commit-Position: refs/heads/master@{#472661}
Committed: https://chromium.googlesource.com/chromium/src/+/0775f98187d5d895b15b46212f55d30956aa946e

[Qiang(Joe) Xu, 2017-05-17 21:29:18]

The CQ bit was checked by warx@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-17 21:31:20]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Qiang(Joe) Xu, 2017-05-17 21:37:41]

Description was changed from

==========
Remove WINDOW_TYPE_V1_PANEL AppWindow type

BUG=691099
==========

to

==========
Remove WINDOW_TYPE_V1_PANEL AppWindow type

Changes:
Currently, panel window is only used as Chrome OS's audio player, which is
WINDOW_TYPE_PANEL. WINDOW_TYPE_V1_PANEL is not a AppWindow type in use any more.
Remove it in code base.

BUG=691099
TEST=covered by tests
==========

[Qiang(Joe) Xu, 2017-05-17 21:37:42]

warx@chromium.org changed reviewers:
+ benwells@chromium.org, oshima@chromium.org

[Qiang(Joe) Xu, 2017-05-17 23:19:10]

Hi all, PTAL, thanks!

[oshima, 2017-05-17 23:21:37]

lgtm

[commit-bot: I haz the power, 2017-05-18 00:27:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-18 00:27:35]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[benwells, 2017-05-18 01:30:47]

lgtm

https://codereview.chromium.org/2886293002/diff/1/chrome/browser/extensions/a...
File chrome/browser/extensions/api/tabs/tabs_api.cc (right):

https://codereview.chromium.org/2886293002/diff/1/chrome/browser/extensions/a...
chrome/browser/extensions/api/tabs/tabs_api.cc:99: #include
"chrome/browser/extensions/api/tabs/ash_panel_contents.h"  // nogncheck
I think this include can be removed. Maybe others can too?

[benwells, 2017-05-18 01:31:07]

On 2017/05/18 01:30:47, benwells wrote:
> lgtm
^^^ should be lgtm with a nit :)

> 
>
https://codereview.chromium.org/2886293002/diff/1/chrome/browser/extensions/a...
> File chrome/browser/extensions/api/tabs/tabs_api.cc (right):
> 
>
https://codereview.chromium.org/2886293002/diff/1/chrome/browser/extensions/a...
> chrome/browser/extensions/api/tabs/tabs_api.cc:99: #include
> "chrome/browser/extensions/api/tabs/ash_panel_contents.h"  // nogncheck
> I think this include can be removed. Maybe others can too?

[Qiang(Joe) Xu, 2017-05-18 02:03:21]

The CQ bit was checked by warx@chromium.org

[Qiang(Joe) Xu, 2017-05-18 02:03:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
benwells@chromium.org, oshima@chromium.org
Link to the patchset: https://codereview.chromium.org/2886293002/#ps20001
(title: "remove unused includes")

[commit-bot: I haz the power, 2017-05-18 02:05:42]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Qiang(Joe) Xu, 2017-05-18 02:24:18]

https://codereview.chromium.org/2886293002/diff/1/chrome/browser/extensions/a...
File chrome/browser/extensions/api/tabs/tabs_api.cc (right):

https://codereview.chromium.org/2886293002/diff/1/chrome/browser/extensions/a...
chrome/browser/extensions/api/tabs/tabs_api.cc:99: #include
"chrome/browser/extensions/api/tabs/ash_panel_contents.h"  // nogncheck
On 2017/05/18 01:30:46, benwells wrote:
> I think this include can be removed. Maybe others can too?

yes, both of them can be removed. Thanks for catching!

[commit-bot: I haz the power, 2017-05-18 04:27:28]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495073001353230,
"parent_rev": "220cde510f9c973d9c2b546a8d8b3c9196cfe7ef", "commit_rev":
"0775f98187d5d895b15b46212f55d30956aa946e"}

[commit-bot: I haz the power, 2017-05-18 04:27:51]

Description was changed from

==========
Remove WINDOW_TYPE_V1_PANEL AppWindow type

Changes:
Currently, panel window is only used as Chrome OS's audio player, which is
WINDOW_TYPE_PANEL. WINDOW_TYPE_V1_PANEL is not a AppWindow type in use any more.
Remove it in code base.

BUG=691099
TEST=covered by tests
==========

to

==========
Remove WINDOW_TYPE_V1_PANEL AppWindow type

Changes:
Currently, panel window is only used as Chrome OS's audio player, which is
WINDOW_TYPE_PANEL. WINDOW_TYPE_V1_PANEL is not a AppWindow type in use any more.
Remove it in code base.

BUG=691099
TEST=covered by tests

Review-Url: https://codereview.chromium.org/2886293002
Cr-Commit-Position: refs/heads/master@{#472661}
Committed:
https://chromium.googlesource.com/chromium/src/+/0775f98187d5d895b15b46212f55...
==========

[commit-bot: I haz the power, 2017-05-18 04:27:56]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0775f98187d5d895b15b46212f55...

[Marc Treib, 2017-05-18 08:27:20]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2891043002/ by treib@chromium.org.

The reason for reverting is: Breaks compile on ChromiumOS x86-generic due to
unused-but-set variable saw_focus_key.