Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Unified Diff: extensions/browser/api/cast_channel/cast_test_util.cc

Issue 2891023002: [cast_channel] Make CastSocket not inherit from ApiResource (Closed)
Patch Set: resolve code review comments from Mark Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/cast_channel/cast_test_util.cc
diff --git a/extensions/browser/api/cast_channel/cast_test_util.cc b/extensions/browser/api/cast_channel/cast_test_util.cc
index 7a115f2bf6d6edb9bef45858ad4cb2f5bf08da4a..f7246746b236c324eae55b3e312785bbb42c5463 100644
--- a/extensions/browser/api/cast_channel/cast_test_util.cc
+++ b/extensions/browser/api/cast_channel/cast_test_util.cc
@@ -35,11 +35,15 @@ MockCastTransportDelegate::~MockCastTransportDelegate() {
}
MockCastSocket::MockCastSocket()
- : CastSocket(kTestExtensionId), mock_transport_(new MockCastTransport) {
-}
+ : mock_transport_(new MockCastTransport),
imcheng 2017/05/24 20:24:32 MockCastTransport() for consistency.
zhaobin 2017/05/24 22:15:07 Done.
+ owner_extension_id_(kTestExtensionId) {}
MockCastSocket::~MockCastSocket() {
}
+const std::string& MockCastSocket::owner_extension_id() const {
+ return owner_extension_id_;
+}
+
net::IPEndPoint CreateIPEndPointForTest() {
return net::IPEndPoint(net::IPAddress(192, 168, 1, 1), 8009);
}

Powered by Google App Engine
This is Rietveld 408576698