Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Side by Side Diff: extensions/browser/api/cast_channel/cast_test_util.cc

Issue 2891023002: [cast_channel] Make CastSocket not inherit from ApiResource (Closed)
Patch Set: resolve code review comments from Mark Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/browser/api/cast_channel/cast_test_util.h" 5 #include "extensions/browser/api/cast_channel/cast_test_util.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "net/base/ip_address.h" 9 #include "net/base/ip_address.h"
10 10
(...skipping 17 matching lines...) Expand all
28 std::unique_ptr<CastTransport::Delegate> delegate) { 28 std::unique_ptr<CastTransport::Delegate> delegate) {
29 delegate_ = std::move(delegate); 29 delegate_ = std::move(delegate);
30 } 30 }
31 31
32 MockCastTransportDelegate::MockCastTransportDelegate() { 32 MockCastTransportDelegate::MockCastTransportDelegate() {
33 } 33 }
34 MockCastTransportDelegate::~MockCastTransportDelegate() { 34 MockCastTransportDelegate::~MockCastTransportDelegate() {
35 } 35 }
36 36
37 MockCastSocket::MockCastSocket() 37 MockCastSocket::MockCastSocket()
38 : CastSocket(kTestExtensionId), mock_transport_(new MockCastTransport) { 38 : mock_transport_(new MockCastTransport),
imcheng 2017/05/24 20:24:32 MockCastTransport() for consistency.
zhaobin 2017/05/24 22:15:07 Done.
39 owner_extension_id_(kTestExtensionId) {}
40 MockCastSocket::~MockCastSocket() {
39 } 41 }
40 MockCastSocket::~MockCastSocket() { 42
43 const std::string& MockCastSocket::owner_extension_id() const {
44 return owner_extension_id_;
41 } 45 }
42 46
43 net::IPEndPoint CreateIPEndPointForTest() { 47 net::IPEndPoint CreateIPEndPointForTest() {
44 return net::IPEndPoint(net::IPAddress(192, 168, 1, 1), 8009); 48 return net::IPEndPoint(net::IPAddress(192, 168, 1, 1), 8009);
45 } 49 }
46 50
47 } // namespace cast_channel 51 } // namespace cast_channel
48 } // namespace api 52 } // namespace api
49 } // namespace extensions 53 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698