[cast_channel] Make CastSocket not inherit from ApiResource

extensions/browser/api/cast_channel/cast_socket_service_unittest.cc

Index: extensions/browser/api/cast_channel/cast_socket_service_unittest.cc
diff --git a/extensions/browser/api/cast_channel/cast_socket_service_unittest.cc b/extensions/browser/api/cast_channel/cast_socket_service_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..187e57fef01ce11e0fbfcc58b67943cfc4da38bb
--- /dev/null
+++ b/extensions/browser/api/cast_channel/cast_socket_service_unittest.cc
@@ -0,0 +1,74 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "extensions/browser/api/cast_channel/cast_socket_service.h"
+#include "content/public/test/test_browser_thread_bundle.h"
+#include "extensions/browser/api/cast_channel/cast_test_util.h"
+
+#include "testing/gtest/include/gtest/gtest.h"
+
+using testing::_;
+
+namespace extensions {
+namespace api {
+namespace cast_channel {
+
+class CastSocketServiceTest : public testing::Test {
+ public:
+  CastSocketServiceTest()
+      : thread_bundle_(content::TestBrowserThreadBundle::IO_MAINLOOP) {}
+
+ protected:
+  content::TestBrowserThreadBundle thread_bundle_;
+  CastSocketService cast_socket_service_;
+};
+
+TEST_F(CastSocketServiceTest, TestAddSocket) {
+  auto* registry = cast_socket_service_.GetOrCreateSocketRegistry();

[imcheng, 2017/05/24 20:24:32]

The counter used for allocating socket ids is a static variable. I think it
might cause problems in this test. Can you try to run this test with
--gtest_repeat=2 to see if that's the case?

[zhaobin, 2017/05/24 22:15:07]

--gtest_repeat=2 passed (think it starts a new process for the second run?)

[imcheng, 2017/05/25 20:20:17]

Ah ok. I would still try not to assume the ids are (0, 1, 2) since the counter
could be modified by other code (e.g., if the test process ran
TestRemoveAndGetSocket then TestAddSocket). Maybe it is sufficient to check that
the ids of the sockets aren't equal?

[zhaobin, 2017/05/25 22:16:21]

Done.

+  int channel_id = 0;
+
+  auto socket1 = base::MakeUnique<MockCastSocket>();
+  EXPECT_CALL(*socket1, set_id(1));
+
+  channel_id = registry->AddSocket(std::move(socket1));
+  EXPECT_EQ(1, channel_id);
+
+  auto socket2 = base::MakeUnique<MockCastSocket>();
+  EXPECT_CALL(*socket2, set_id(2));
+
+  auto* socket_ptr = socket2.get();
+  channel_id = registry->AddSocket(std::move(socket2));
+  EXPECT_EQ(2, channel_id);
+
+  auto removed_socket = registry->RemoveSocket(channel_id);
+  EXPECT_EQ(socket_ptr, removed_socket.get());
+
+  auto socket3 = base::MakeUnique<MockCastSocket>();
+  EXPECT_CALL(*socket3, set_id(3));
+
+  channel_id = registry->AddSocket(std::move(socket3));
+  EXPECT_EQ(3, channel_id);
+}
+
+TEST_F(CastSocketServiceTest, TestRemoveAndGetSocket) {
+  auto* registry = cast_socket_service_.GetOrCreateSocketRegistry();
+  int channel_id = 1;
+  auto* socket_ptr = registry->GetSocket(channel_id);
+  EXPECT_FALSE(socket_ptr);
+  auto socket = registry->RemoveSocket(channel_id);
+  EXPECT_FALSE(socket);
+
+  auto mock_socket = base::MakeUnique<MockCastSocket>();
+  EXPECT_CALL(*mock_socket, set_id(_));
+
+  auto* mock_socket_ptr = mock_socket.get();
+  channel_id = registry->AddSocket(std::move(mock_socket));
+  EXPECT_EQ(mock_socket_ptr, registry->GetSocket(channel_id));
+  socket = registry->RemoveSocket(channel_id);
+  EXPECT_TRUE(socket);
+}
+
+}  // namespace cast_channel
+}  // namespace api
+}  // namespace extensions