Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2890943003: [Devtools][Regression] Fixed network film strip sometimes errored (Closed)

Created:
3 years, 7 months ago by allada
Modified:
3 years, 7 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Devtools][Regression] Fixed network film strip sometimes errored Fixes bug where if the overviewPane was not shown the filmStrip would never show and throw an exception in network panel. Offending patch: https://codereview.chromium.org/2857833002/ R=pfeldman BUG=723659 Review-Url: https://codereview.chromium.org/2890943003 Cr-Commit-Position: refs/heads/master@{#472651} Committed: https://chromium.googlesource.com/chromium/src/+/1cb9864601dad078281ff870a23b308d2e88cb50

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -2 lines) Patch
A third_party/WebKit/LayoutTests/inspector/network/network-filmstrip-overview-showing.html View 1 chunk +69 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/network/network-filmstrip-overview-showing-expected.txt View 1 chunk +23 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js View 4 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
allada
PTL
3 years, 7 months ago (2017-05-17 21:07:41 UTC) #1
pfeldman
lgtm
3 years, 7 months ago (2017-05-17 21:28:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2890943003/1
3 years, 7 months ago (2017-05-17 21:31:14 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/458241)
3 years, 7 months ago (2017-05-17 23:56:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2890943003/1
3 years, 7 months ago (2017-05-18 00:05:48 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-18 03:49:37 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1cb9864601dad078281ff870a23b...

Powered by Google App Engine
This is Rietveld 408576698