Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js

Issue 2890943003: [Devtools][Regression] Fixed network film strip sometimes errored (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/network/network-filmstrip-overview-showing-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js
index ad034bdf59a62c37e85f3027a42c05e1c0dae0a6..4546ccc77dca90e6045515668afe166bcf188215 100644
--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js
+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js
@@ -51,6 +51,8 @@ Network.NetworkPanel = class extends UI.Panel {
this._filterBar = new UI.FilterBar('networkPanel', true);
this._filterBar.show(this.element);
+ this._filmStripPlaceholderElement = this.element.createChild('div');
+
// Create top overview component.
this._overviewPane = new PerfUI.TimelineOverviewPane('network');
this._overviewPane.addEventListener(
@@ -58,6 +60,8 @@ Network.NetworkPanel = class extends UI.Panel {
this._overviewPane.element.id = 'network-overview-panel';
this._networkOverview = new Network.NetworkOverview();
this._overviewPane.setOverviewControls([this._networkOverview]);
+ this._overviewPlaceholderElement = this.element.createChild('div');
+
this._calculator = new Network.NetworkTransferTimeCalculator();
this._splitWidget = new UI.SplitWidget(true, false, 'networkPanelSplitViewState');
@@ -296,7 +300,7 @@ Network.NetworkPanel = class extends UI.Panel {
_toggleShowOverview() {
var toggled = this._networkLogShowOverviewSetting.get();
if (toggled)
- this._overviewPane.show(this.element, this._splitWidget.element);
+ this._overviewPane.show(this._overviewPlaceholderElement);
else
this._overviewPane.detach();
this.doResize();
@@ -310,7 +314,7 @@ Network.NetworkPanel = class extends UI.Panel {
this._filmStripView.element.classList.add('network-film-strip');
this._filmStripRecorder =
new Network.NetworkPanel.FilmStripRecorder(this._networkLogView.timeCalculator(), this._filmStripView);
- this._filmStripView.show(this.element, this._overviewPane.element);
+ this._filmStripView.show(this._filmStripPlaceholderElement);
this._filmStripView.addEventListener(PerfUI.FilmStripView.Events.FrameSelected, this._onFilmFrameSelected, this);
this._filmStripView.addEventListener(PerfUI.FilmStripView.Events.FrameEnter, this._onFilmFrameEnter, this);
this._filmStripView.addEventListener(PerfUI.FilmStripView.Events.FrameExit, this._onFilmFrameExit, this);
« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/network/network-filmstrip-overview-showing-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698