Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 2890863002: cocoa: move first run bubble's arrow (Closed)

Created:
3 years, 7 months ago by Elly Fong-Jones
Modified:
3 years, 7 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

cocoa: move first run bubble's arrow Right now, the left edge of the bubble lines up with the left edge of the omnibox, but that leaves the arrow pointing at nothing. Move the bubble so the arrow points at the location icon. BUG=719117 Review-Url: https://codereview.chromium.org/2890863002 Cr-Commit-Position: refs/heads/master@{#472537} Committed: https://chromium.googlesource.com/chromium/src/+/b1cf560ccc8850e6fd059c3f32cde1a88787537b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -9 lines) Patch
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm View 1 chunk +3 lines, -9 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Elly Fong-Jones
rsesek: ptal? :)
3 years, 7 months ago (2017-05-17 17:34:41 UTC) #3
Robert Sesek
LGTM
3 years, 7 months ago (2017-05-17 18:13:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2890863002/1
3 years, 7 months ago (2017-05-17 18:45:10 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-17 19:38:31 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b1cf560ccc8850e6fd059c3f32cd...

Powered by Google App Engine
This is Rietveld 408576698